chrome/browser/guest_view/extension_options/extension_options_apitest.cc - Issue 471053003: Allow links inside <extensionoptions> to be opened in new tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/extension_options/extension_options_apitest.cc

Issue 471053003: Allow links inside <extensionoptions> to be opened in new tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Run formatter and make the WebUI test also use LoadExtension Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_webui_apitest.cc ('k') | chrome/browser/guest_view/extension_options/extension_options_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/extension_options/extension_options_apitest.cc

diff --git a/chrome/browser/guest_view/extension_options/extension_options_apitest.cc b/chrome/browser/guest_view/extension_options/extension_options_apitest.cc

index 1de892f5a2437e807bcc856aa1b6d2269a12025d..77027b1526b0d10f82943f12d5d9b6b68b861849 100644

--- a/chrome/browser/guest_view/extension_options/extension_options_apitest.cc

+++ b/chrome/browser/guest_view/extension_options/extension_options_apitest.cc

@@ -32,7 +32,7 @@ class ExtensionOptionsApiTest : public ExtensionApiTest {

IN_PROC_BROWSER_TEST_F(ExtensionOptionsApiTest, ExtensionCanEmbedOwnOptions) {

base::FilePath extension_dir =

test_data_dir_.AppendASCII("extension_options").AppendASCII("embed_self");

- ASSERT_TRUE(InstallExtension(extension_dir, 1));

+ ASSERT_TRUE(LoadExtension(extension_dir));

ASSERT_TRUE(RunExtensionSubtest("extension_options/embed_self", "test.html"));

}