content/browser/web_contents/web_contents_impl.cc - Issue 471053003: Allow links inside <extensionoptions> to be opened in new tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 471053003: Allow links inside <extensionoptions> to be opened in new tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/guest_view/extension_options/extension_options_guest.cc ('K') | « chrome/browser/guest_view/extension_options/extension_options_guest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 57ed3e75fd96487b72b2d9d8ce53688eacb8468a..ff001ce0549f3f262ed6ec28911e97461eea0fa2 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -1513,7 +1513,7 @@ void WebContentsImpl::CreateNewWindow(

create_params.initial_size = GetContainerBounds().size();

new_contents = static_cast<WebContentsImpl*>(

WebContents::Create(create_params));

- } else {

+ } else {

not at google - send to devlin 2014/08/14 23:14:37 you might want to undo this, so that you don't nee

ericzeng 2014/08/15 20:08:23 ugh

new_contents = GetBrowserPluginGuest()->CreateNewGuestWindow(create_params);

}

new_contents->GetController().SetSessionStorageNamespace(