Allow links inside <extensionoptions> to be opened in new tabs

chrome/browser/guest_view/extension_options/extension_options_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/guest_view/extension_options/extension_options_guest.h"
 
 #include "base/values.h"
 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
+#include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/guest_view/extension_options/extension_options_constants.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/extensions/api/extension_options_internal.h"
 #include "chrome/common/extensions/manifest_url_handler.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/extension_function_dispatcher.h"
 #include "extensions/browser/extension_registry.h"
+#include "extensions/browser/guest_view/guest_view_manager.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/feature_switch.h"
 #include "extensions/common/permissions/permissions_data.h"
 #include "ipc/ipc_message_macros.h"
 
 using content::WebContents;
 using namespace extensions::api;
 
 // static
@@ skipping 142 matching lines @@
   int min_width = 0;
   extra_params()->GetInteger(extensionoptions::kAttributeMinHeight,
                              &min_height);
   extra_params()->GetInteger(extensionoptions::kAttributeMinWidth, &min_width);
 
   // Call SetAutoSize to apply all the appropriate validation and clipping of
   // values.
   SetAutoSize(
       true, gfx::Size(min_width, min_height), gfx::Size(max_width, max_height));
 }
+
+content::WebContents* ExtensionOptionsGuest::CreateNewGuestWindow(
+    const content::WebContents::CreateParams& create_params) {
+  extensions::GuestViewManager* guest_manager =
+      extensions::GuestViewManager::FromBrowserContext(browser_context());
+  return guest_manager->CreateGuestWithWebContentsParams(
+      ExtensionOptionsGuest::Type,
+      embedder_extension_id(),
+      embedder_web_contents()->GetRenderProcessHost()->GetID(),
+      create_params);
+}
+
+void ExtensionOptionsGuest::WebContentsCreated(
+    content::WebContents* source_contents,
+    int opener_render_frame_id,
+    const base::string16& frame_name,
+    const GURL& target_url,
+    WebContents* new_contents) {
+  Browser* browser =
+      chrome::FindBrowserWithWebContents(embedder_web_contents());
+  content::OpenURLParams params(target_url,
+                                content::Referrer(),

[not at google - send to devlin, 2014/08/14 23:14:37]

I'm not sure if there should be a Referrer here. This link is definitely coming
from somewhere - the URL of the host - but I'm not sure what the
WebReferrerPolicy should be. Nor if it's actually relevant in this case.

[ericzeng, 2014/08/15 20:08:22]

Are you saying that I should be finding what the referrer would be if this was
in a tab and using that instead?

[not at google - send to devlin, 2014/08/15 20:14:32]

I would have thought that in a tab the referrer would be the
chrome-extensions:// page, but I actually don't see that being set for
chrome-extensions:// even in a tab. I guess we hide it, probably deliberately.
So you have nothing to worry about here.

+                                NEW_FOREGROUND_TAB,
+                                content::PAGE_TRANSITION_LINK,
+                                false);
+  browser->OpenURL(params);
+  browser->window()->Show();

[not at google - send to devlin, 2014/08/14 23:14:37]

Ideally we'd respect choices like "open in new tab" etc. What are the context
menu options on the link? How do the arguments change?

[ericzeng, 2014/08/15 20:08:22]

The link context menu has all of the normal options - open link in new tab, open
link in new window, open link in incognito window, save link as... etc. None of
the navigation options work right now, I'll see if I can fix that in the next
patch. 

[not at google - send to devlin, 2014/08/15 20:14:32]

SGTM.

[Fady Samuel, 2014/08/15 20:22:05]

Take a look at the link below for more information on how to customize the
context menu of your element.

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/gue...

+}