Fixing broken images

This passes the URL of the diff image to the front-end, thus removing the need to keep frontend code for URL generation in sync with the backend. 

BUG=skia:
NOTREECHECKS=true
NOTRY=true

Committed: https://skia.googlesource.com/skia/+/a1aa5c280662faf0df54865f69449d13b8b0cc65

[epoger, 2014-08-14 18:06:35]

I like it!  Just little cleanup remaining.

https://codereview.chromium.org/471033003/diff/1/gm/rebaseline_server/imagepa...
File gm/rebaseline_server/imagepair_test.py (right):

https://codereview.chromium.org/471033003/diff/1/gm/rebaseline_server/imagepa...
gm/rebaseline_server/imagepair_test.py:93: 'whiteDiffUrl':
'arcofzorro_16206093933823793653_png_png-vs-arcofzorro_13786535001616823825_png_png.png',
Maybe in a followup CL, we could replace the repeated "_png_png" with just
"_png".  No need to do it now.

https://codereview.chromium.org/471033003/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/live-loader.js (right):

https://codereview.chromium.org/471033003/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/live-loader.js:1043: // TODO (stephana): this is a
temporary fix. A fix is in the works
delete the TODO!  Hooray!

https://codereview.chromium.org/471033003/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/471033003/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/loader.js:1034: // TODO (stephana): this is a
temporary fix. A fix is in the works
delete the TODO

[stephana, 2014-08-14 18:28:22]

https://codereview.chromium.org/471033003/diff/1/gm/rebaseline_server/imagepa...
File gm/rebaseline_server/imagepair_test.py (right):

https://codereview.chromium.org/471033003/diff/1/gm/rebaseline_server/imagepa...
gm/rebaseline_server/imagepair_test.py:93: 'whiteDiffUrl':
'arcofzorro_16206093933823793653_png_png-vs-arcofzorro_13786535001616823825_png_png.png',
On 2014/08/14 18:06:35, epoger wrote:
> Maybe in a followup CL, we could replace the repeated "_png_png" with just
> "_png".  No need to do it now.

Agreed. The repeated 'png' actually broke the front-end in the first place, but
if we fix it on the backend it will automatically show up in the front-end. I'll
do a follow up CL. 
http://skbug.com/2835

https://codereview.chromium.org/471033003/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/live-loader.js (right):

https://codereview.chromium.org/471033003/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/live-loader.js:1043: // TODO (stephana): this is a
temporary fix. A fix is in the works
On 2014/08/14 18:06:35, epoger wrote:
> delete the TODO!  Hooray!

Acknowledged.

https://codereview.chromium.org/471033003/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/471033003/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/loader.js:1034: // TODO (stephana): this is a
temporary fix. A fix is in the works
On 2014/08/14 18:06:35, epoger wrote:
> delete the TODO

Done.

[epoger, 2014-08-14 18:30:10]

lgtm

[stephana, 2014-08-15 13:00:34]

The CQ bit was checked by stephana@google.com

[commit-bot: I haz the power, 2014-08-15 13:00:52]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/stephana@google.com/471033003/20001

[commit-bot: I haz the power, 2014-08-15 13:00:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-15 13:00:58]

Presubmit check for 471033003-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Pylint (2 files) (1.09s) failed
************* Module
/b/infra_internal/commit_queue/workdir/skia/gm/rebaseline_server/imagepair_test.py
C0301: 92,0: Line too long (120/80)
C0301: 93,0: Line too long (125/80)
C0301:120,0: Line too long (148/80)
C0301:121,0: Line too long (152/80)


Presubmit checks took 1.7s to calculate.

[stephana, 2014-08-15 13:26:14]

The CQ bit was checked by stephana@google.com

[commit-bot: I haz the power, 2014-08-15 13:26:55]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/stephana@google.com/471033003/40001

[stephana, 2014-08-15 13:53:02]

The CQ bit was unchecked by stephana@google.com

[stephana, 2014-08-15 13:53:04]

The CQ bit was checked by stephana@google.com

[commit-bot: I haz the power, 2014-08-15 13:53:15]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/stephana@google.com/471033003/40001

[commit-bot: I haz the power, 2014-08-15 13:53:30]

Committed patchset #3 (40001) as a1aa5c280662faf0df54865f69449d13b8b0cc65