Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 471023003: Make sure the new confirmation bubble is always shown upon signin (Closed)

Created:
6 years, 4 months ago by guohui
Modified:
6 years, 4 months ago
CC:
chromium-reviews, tim+watch_chromium.org, tfarina, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

1. migrate desktop FRE to use new confirmation bubble 2. show new confirmation bubble when signing in from the new avatar menu and a modal warning dialog is displayed BUG=402130, 402423 R=asvitkine@chromium.org, rogerta@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290032

Patch Set 1 : #

Patch Set 2 : show new confirmation bubble after modal dialog closed #

Total comments: 5

Patch Set 3 : roger's comments addressed and rebased #

Total comments: 4

Patch Set 4 : nits fixed #

Patch Set 5 : refactor per discussion with roger #

Patch Set 6 : fix mac after refactoring #

Patch Set 7 : fix create new profile flow #

Patch Set 8 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -94 lines) Patch
M chrome/browser/profiles/profile_window.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_window.cc View 1 2 3 4 5 6 7 1 chunk +19 lines, -10 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm View 1 2 3 6 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 2 3 4 5 6 7 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 2 3 4 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.h View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 1 2 3 4 5 6 6 chunks +20 lines, -28 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 3 4 5 6 7 9 chunks +16 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 2 3 4 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
guohui
Hey Roger, could you please review the CL? Thanks, Hui
6 years, 4 months ago (2014-08-14 18:56:33 UTC) #1
guohui
+sky@ for owner review of ui/views/... +asvitkine@ for owner review of ui/cooca/...
6 years, 4 months ago (2014-08-14 20:18:53 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/471023003/diff/120001/chrome/browser/profiles/profile_window.h File chrome/browser/profiles/profile_window.h (right): https://codereview.chromium.org/471023003/diff/120001/chrome/browser/profiles/profile_window.h#newcode98 chrome/browser/profiles/profile_window.h:98: TutorialMode& tutorial_mode); Output args should be pointers. https://codereview.chromium.org/471023003/diff/120001/chrome/browser/ui/sync/one_click_signin_helper.cc ...
6 years, 4 months ago (2014-08-14 21:54:09 UTC) #3
guohui
Thanks Roger. ping sky@ and alexei@ for owner review? https://codereview.chromium.org/471023003/diff/120001/chrome/browser/profiles/profile_window.h File chrome/browser/profiles/profile_window.h (right): https://codereview.chromium.org/471023003/diff/120001/chrome/browser/profiles/profile_window.h#newcode98 chrome/browser/profiles/profile_window.h:98: ...
6 years, 4 months ago (2014-08-15 15:42:40 UTC) #4
guohui
Thanks Roger. ping sky@ and alexei@ for owner review?
6 years, 4 months ago (2014-08-15 15:42:42 UTC) #5
Roger Tawa OOO till Jul 10th
https://codereview.chromium.org/471023003/diff/120001/chrome/browser/ui/sync/one_click_signin_sync_starter.cc File chrome/browser/ui/sync/one_click_signin_sync_starter.cc (right): https://codereview.chromium.org/471023003/diff/120001/chrome/browser/ui/sync/one_click_signin_sync_starter.cc#newcode480 chrome/browser/ui/sync/one_click_signin_sync_starter.cc:480: DisplayFinalConfirmationBubble(base::string16()); What if you always call DisplayFinalConfirmationBubble() here, and ...
6 years, 4 months ago (2014-08-15 15:49:13 UTC) #6
Alexei Svitkine (slow)
LGTM % nits https://codereview.chromium.org/471023003/diff/140001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm File chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm (right): https://codereview.chromium.org/471023003/diff/140001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm#newcode75 chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm:75: withTutorialMode:profiles::TUTORIAL_MODE_NONE Nit: ObjC style is to ...
6 years, 4 months ago (2014-08-15 15:51:47 UTC) #7
guohui
https://codereview.chromium.org/471023003/diff/120001/chrome/browser/ui/sync/one_click_signin_sync_starter.cc File chrome/browser/ui/sync/one_click_signin_sync_starter.cc (right): https://codereview.chromium.org/471023003/diff/120001/chrome/browser/ui/sync/one_click_signin_sync_starter.cc#newcode480 chrome/browser/ui/sync/one_click_signin_sync_starter.cc:480: DisplayFinalConfirmationBubble(base::string16()); as discussed yesterday, that would be a cleaner ...
6 years, 4 months ago (2014-08-15 15:57:52 UTC) #8
guohui
https://codereview.chromium.org/471023003/diff/140001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm File chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm (right): https://codereview.chromium.org/471023003/diff/140001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm#newcode75 chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm:75: withTutorialMode:profiles::TUTORIAL_MODE_NONE On 2014/08/15 15:51:47, Alexei Svitkine wrote: > Nit: ...
6 years, 4 months ago (2014-08-15 16:07:00 UTC) #9
sky
LGTM
6 years, 4 months ago (2014-08-15 19:05:47 UTC) #10
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 4 months ago (2014-08-15 19:06:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/471023003/200001
6 years, 4 months ago (2014-08-15 19:09:12 UTC) #12
guohui
The CQ bit was unchecked by guohui@chromium.org
6 years, 4 months ago (2014-08-15 19:45:41 UTC) #13
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 4 months ago (2014-08-15 19:55:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/471023003/220001
6 years, 4 months ago (2014-08-15 19:57:52 UTC) #15
guohui
6 years, 4 months ago (2014-08-15 22:53:10 UTC) #16
Message was sent while issue was closed. 
Committed patchset #8 manually as 290032 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698