Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 471013002: Use profiling lock in ScreencastView to detect if Timeline or Profiler is started (Closed)

Created:
6 years, 4 months ago by yurys
Modified:
6 years, 4 months ago
Reviewers:
alph, sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Use profiling lock in ScreencastView to detect if Timeline or Profiler is started Instead of listening to particular model notifications it is enough to listen for profiling lock changes. BUG=403684 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180352

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased after making profiling lock global #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -37 lines) Patch
M Source/devtools/front_end/screencast/ScreencastView.js View 1 2 5 chunks +6 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yurys
6 years, 4 months ago (2014-08-14 14:44:55 UTC) #1
sergeyv
https://codereview.chromium.org/471013002/diff/1/Source/devtools/front_end/screencast/ScreencastView.js File Source/devtools/front_end/screencast/ScreencastView.js (right): https://codereview.chromium.org/471013002/diff/1/Source/devtools/front_end/screencast/ScreencastView.js#newcode98 Source/devtools/front_end/screencast/ScreencastView.js:98: this._target.profilingLock.addEventListener(WebInspector.Lock.Events.StateChanged, this._onProfilingStateChange, this); Lets make profiling lock global (not ...
6 years, 4 months ago (2014-08-14 15:01:34 UTC) #2
sergeyv
6 years, 4 months ago (2014-08-14 15:01:35 UTC) #3
yurys
https://codereview.chromium.org/471013002/diff/1/Source/devtools/front_end/screencast/ScreencastView.js File Source/devtools/front_end/screencast/ScreencastView.js (right): https://codereview.chromium.org/471013002/diff/1/Source/devtools/front_end/screencast/ScreencastView.js#newcode98 Source/devtools/front_end/screencast/ScreencastView.js:98: this._target.profilingLock.addEventListener(WebInspector.Lock.Events.StateChanged, this._onProfilingStateChange, this); On 2014/08/14 15:01:34, sergeyv wrote: > ...
6 years, 4 months ago (2014-08-14 15:29:09 UTC) #4
yurys
Rebased on top of https://codereview.chromium.org/475803002/. PTAL
6 years, 4 months ago (2014-08-14 16:03:24 UTC) #5
pfeldman
lgtm
6 years, 4 months ago (2014-08-15 10:59:49 UTC) #6
yurys
6 years, 4 months ago (2014-08-15 11:30:11 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 manually as 180352 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698