Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 470983004: Move blink<->cc bindings to cc/blink (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org, Elliot Glaysher, enne (OOO)
Project:
chromium
Visibility:
Public.

Description

Move blink<->cc bindings to cc/blink These files provide the implementations of the public Blink API that bind to the cc implementation. This moves them out of content/ into a subdirectory of cc/ so that we can reuse these files in mojo which can depend on cc/ and on blink but not on content/. To make sure we don't introduce dependencies from cc/ on blink proper, cc/DEPS forbids including cc/blink/ and cc/blink/DEPS allows using the blink headers. cc_blink is built as a separate component to avoid linking anything from blink into targets that don't care about the blink bindings (such as the browser compositor). R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290464

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : dependency / GN fixes #

Patch Set 7 : restrictive DEPS entries #

Patch Set 8 : add -cc/blink to DEPS files that want to use cc but not blink bindings #

Patch Set 9 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+588 lines, -3981 lines) Patch
M BUILD.gn View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M android_webview/browser/DEPS View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M build/all.gyp View 1 2 3 9 chunks +9 lines, -0 lines 0 comments Download
M cc/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
A cc/blink/BUILD.gn View 1 2 3 4 5 1 chunk +86 lines, -0 lines 0 comments Download
A cc/blink/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A cc/blink/cc_blink.gyp View 1 2 3 4 5 1 chunk +70 lines, -0 lines 0 comments Download
A cc/blink/cc_blink_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
A cc/blink/cc_blink_tests.gyp View 1 2 3 4 1 chunk +50 lines, -0 lines 0 comments Download
A + cc/blink/scrollbar_impl.h View 3 chunks +5 lines, -6 lines 0 comments Download
A + cc/blink/scrollbar_impl.cc View 3 chunks +3 lines, -4 lines 0 comments Download
A + cc/blink/web_animation_curve_common.h View 2 chunks +5 lines, -6 lines 0 comments Download
A + cc/blink/web_animation_curve_common.cc View 2 chunks +3 lines, -4 lines 0 comments Download
A + cc/blink/web_animation_impl.h View 3 chunks +7 lines, -8 lines 0 comments Download
A + cc/blink/web_animation_impl.cc View 3 chunks +7 lines, -8 lines 0 comments Download
A + cc/blink/web_animation_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
A + cc/blink/web_blend_mode.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + cc/blink/web_compositor_support_impl.h View 3 chunks +7 lines, -8 lines 0 comments Download
A + cc/blink/web_compositor_support_impl.cc View 3 chunks +16 lines, -17 lines 0 comments Download
A + cc/blink/web_content_layer_impl.h View 3 chunks +8 lines, -10 lines 0 comments Download
A + cc/blink/web_content_layer_impl.cc View 3 chunks +3 lines, -4 lines 0 comments Download
A + cc/blink/web_external_bitmap_impl.h View 2 chunks +8 lines, -9 lines 0 comments Download
A + cc/blink/web_external_bitmap_impl.cc View 2 chunks +3 lines, -4 lines 0 comments Download
A + cc/blink/web_external_texture_layer_impl.h View 3 chunks +12 lines, -13 lines 0 comments Download
A + cc/blink/web_external_texture_layer_impl.cc View 4 chunks +7 lines, -8 lines 0 comments Download
A + cc/blink/web_filter_animation_curve_impl.h View 3 chunks +7 lines, -8 lines 0 comments Download
A + cc/blink/web_filter_animation_curve_impl.cc View 2 chunks +5 lines, -6 lines 0 comments Download
A + cc/blink/web_filter_operations_impl.h View 2 chunks +7 lines, -8 lines 0 comments Download
A + cc/blink/web_filter_operations_impl.cc View 3 chunks +3 lines, -4 lines 0 comments Download
A + cc/blink/web_float_animation_curve_impl.h View 3 chunks +7 lines, -8 lines 0 comments Download
A + cc/blink/web_float_animation_curve_impl.cc View 2 chunks +4 lines, -5 lines 0 comments Download
A + cc/blink/web_float_animation_curve_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
A + cc/blink/web_image_layer_impl.h View 2 chunks +7 lines, -8 lines 0 comments Download
A + cc/blink/web_image_layer_impl.cc View 2 chunks +7 lines, -8 lines 0 comments Download
A + cc/blink/web_layer_impl.h View 6 chunks +16 lines, -26 lines 0 comments Download
A + cc/blink/web_layer_impl.cc View 6 chunks +10 lines, -21 lines 0 comments Download
A + cc/blink/web_layer_impl_fixed_bounds.h View 4 chunks +9 lines, -11 lines 0 comments Download
A + cc/blink/web_layer_impl_fixed_bounds.cc View 3 chunks +3 lines, -4 lines 0 comments Download
A + cc/blink/web_layer_impl_fixed_bounds_unittest.cc View 1 2 3 6 chunks +3 lines, -7 lines 0 comments Download
A + cc/blink/web_nine_patch_layer_impl.h View 2 chunks +7 lines, -8 lines 0 comments Download
A + cc/blink/web_nine_patch_layer_impl.cc View 2 chunks +5 lines, -6 lines 0 comments Download
A + cc/blink/web_scroll_offset_animation_curve_impl.h View 3 chunks +7 lines, -8 lines 0 comments Download
A + cc/blink/web_scroll_offset_animation_curve_impl.cc View 2 chunks +4 lines, -5 lines 0 comments Download
A + cc/blink/web_scrollbar_layer_impl.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + cc/blink/web_scrollbar_layer_impl.cc View 3 chunks +5 lines, -6 lines 0 comments Download
A + cc/blink/web_to_cc_animation_delegate_adapter.h View 2 chunks +5 lines, -6 lines 0 comments Download
A + cc/blink/web_to_cc_animation_delegate_adapter.cc View 2 chunks +3 lines, -4 lines 0 comments Download
A + cc/blink/web_transform_animation_curve_impl.h View 3 chunks +7 lines, -8 lines 0 comments Download
A + cc/blink/web_transform_animation_curve_impl.cc View 2 chunks +5 lines, -6 lines 0 comments Download
A + cc/blink/web_transform_operations_impl.h View 2 chunks +7 lines, -8 lines 0 comments Download
A + cc/blink/web_transform_operations_impl.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/DEPS View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/content_renderer.gypi View 2 chunks +1 line, -38 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/child_frame_compositing_helper.cc View 3 chunks +2 lines, -2 lines 0 comments Download
D content/renderer/compositor_bindings/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D content/renderer/compositor_bindings/PRESUBMIT.py View 1 chunk +0 lines, -33 lines 0 comments Download
D content/renderer/compositor_bindings/scrollbar_impl.h View 1 chunk +0 lines, -51 lines 0 comments Download
D content/renderer/compositor_bindings/scrollbar_impl.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D content/renderer/compositor_bindings/web_animation_curve_common.h View 1 chunk +0 lines, -21 lines 0 comments Download
D content/renderer/compositor_bindings/web_animation_curve_common.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D content/renderer/compositor_bindings/web_animation_impl.h View 1 chunk +0 lines, -61 lines 0 comments Download
D content/renderer/compositor_bindings/web_animation_impl.cc View 1 chunk +0 lines, -170 lines 0 comments Download
D content/renderer/compositor_bindings/web_animation_unittest.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D content/renderer/compositor_bindings/web_blend_mode.h View 1 chunk +0 lines, -107 lines 0 comments Download
D content/renderer/compositor_bindings/web_compositor_support_impl.h View 1 chunk +0 lines, -66 lines 0 comments Download
D content/renderer/compositor_bindings/web_compositor_support_impl.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D content/renderer/compositor_bindings/web_content_layer_impl.h View 1 chunk +0 lines, -62 lines 0 comments Download
D content/renderer/compositor_bindings/web_content_layer_impl.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D content/renderer/compositor_bindings/web_external_bitmap_impl.h View 1 chunk +0 lines, -47 lines 0 comments Download
D content/renderer/compositor_bindings/web_external_bitmap_impl.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D content/renderer/compositor_bindings/web_external_texture_layer_impl.h View 1 chunk +0 lines, -73 lines 0 comments Download
D content/renderer/compositor_bindings/web_external_texture_layer_impl.cc View 1 chunk +0 lines, -126 lines 0 comments Download
D content/renderer/compositor_bindings/web_filter_animation_curve_impl.h View 1 chunk +0 lines, -51 lines 0 comments Download
D content/renderer/compositor_bindings/web_filter_animation_curve_impl.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D content/renderer/compositor_bindings/web_filter_operations_impl.h View 1 chunk +0 lines, -50 lines 0 comments Download
D content/renderer/compositor_bindings/web_filter_operations_impl.cc View 1 chunk +0 lines, -96 lines 0 comments Download
D content/renderer/compositor_bindings/web_float_animation_curve_impl.h View 1 chunk +0 lines, -54 lines 0 comments Download
D content/renderer/compositor_bindings/web_float_animation_curve_impl.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D content/renderer/compositor_bindings/web_float_animation_curve_unittest.cc View 1 chunk +0 lines, -235 lines 0 comments Download
D content/renderer/compositor_bindings/web_image_layer_impl.h View 1 chunk +0 lines, -35 lines 0 comments Download
D content/renderer/compositor_bindings/web_image_layer_impl.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D content/renderer/compositor_bindings/web_layer_impl.h View 1 chunk +0 lines, -162 lines 0 comments Download
D content/renderer/compositor_bindings/web_layer_impl.cc View 1 chunk +0 lines, -490 lines 0 comments Download
D content/renderer/compositor_bindings/web_layer_impl_fixed_bounds.h View 1 chunk +0 lines, -52 lines 0 comments Download
D content/renderer/compositor_bindings/web_layer_impl_fixed_bounds.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D content/renderer/compositor_bindings/web_layer_impl_fixed_bounds_unittest.cc View 1 chunk +0 lines, -181 lines 0 comments Download
D content/renderer/compositor_bindings/web_nine_patch_layer_impl.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/renderer/compositor_bindings/web_nine_patch_layer_impl.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D content/renderer/compositor_bindings/web_scroll_offset_animation_curve_impl.h View 1 chunk +0 lines, -46 lines 0 comments Download
D content/renderer/compositor_bindings/web_scroll_offset_animation_curve_impl.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D content/renderer/compositor_bindings/web_scrollbar_layer_impl.h View 1 chunk +0 lines, -48 lines 0 comments Download
D content/renderer/compositor_bindings/web_scrollbar_layer_impl.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D content/renderer/compositor_bindings/web_to_cc_animation_delegate_adapter.h View 1 chunk +0 lines, -36 lines 0 comments Download
D content/renderer/compositor_bindings/web_to_cc_animation_delegate_adapter.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D content/renderer/compositor_bindings/web_transform_animation_curve_impl.h View 1 chunk +0 lines, -53 lines 0 comments Download
D content/renderer/compositor_bindings/web_transform_animation_curve_impl.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D content/renderer/compositor_bindings/web_transform_operations_impl.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/renderer/compositor_bindings/web_transform_operations_impl.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 5 6 7 5 chunks +9 lines, -8 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 3 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.h View 3 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 1 2 3 4 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 7 4 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/test_webkit_platform_support.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M mojo/aura/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M mojo/cc/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M mojo/examples/aura_demo/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M mojo/examples/browser/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M mojo/examples/compositor_app/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M mojo/examples/keyboard/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M mojo/examples/surfaces_app/DEPS View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/surfaces/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/view_manager/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/bench/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/DEPS View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ui/snapshot/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jamesr
There are various parts of the blink platform API that abstract over different libraries that ...
6 years, 4 months ago (2014-08-14 23:32:34 UTC) #1
darin (slow to review)
LGTM
6 years, 4 months ago (2014-08-14 23:58:23 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-18 22:52:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/470983004/140001
6 years, 4 months ago (2014-08-18 22:53:05 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-19 00:28:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-19 01:01:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/6849)
6 years, 4 months ago (2014-08-19 01:01:19 UTC) #7
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-19 01:21:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/470983004/160001
6 years, 4 months ago (2014-08-19 01:22:56 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 02:47:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #9 (160001) as 290464

Powered by Google App Engine
This is Rietveld 408576698