Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 470983002: Gallery: Load gallery items by chunk on startup. (Closed)

Created:
6 years, 4 months ago by hirono
Modified:
6 years, 4 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Gallery: Load gallery items by chunk on startup. BUG=chrome-os-partner:28087 TEST=run on link Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289922

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Remove unused method. #

Total comments: 2

Patch Set 4 : . #

Total comments: 4

Patch Set 5 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -85 lines) Patch
M ui/file_manager/gallery/js/gallery.js View 1 2 3 4 4 chunks +121 lines, -79 lines 0 comments Download
M ui/file_manager/gallery/js/mosaic_mode.js View 5 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 4 months ago (2014-08-14 12:34:36 UTC) #1
yoshiki
https://codereview.chromium.org/470983002/diff/40001/ui/file_manager/gallery/js/gallery.js File ui/file_manager/gallery/js/gallery.js (right): https://codereview.chromium.org/470983002/diff/40001/ui/file_manager/gallery/js/gallery.js#newcode446 ui/file_manager/gallery/js/gallery.js:446: var loadChunk = function(firstChunk) { loadChunk is called many ...
6 years, 4 months ago (2014-08-15 05:47:40 UTC) #2
hirono
Thank you! https://codereview.chromium.org/470983002/diff/40001/ui/file_manager/gallery/js/gallery.js File ui/file_manager/gallery/js/gallery.js (right): https://codereview.chromium.org/470983002/diff/40001/ui/file_manager/gallery/js/gallery.js#newcode446 ui/file_manager/gallery/js/gallery.js:446: var loadChunk = function(firstChunk) { On 2014/08/15 ...
6 years, 4 months ago (2014-08-15 07:05:25 UTC) #3
yoshiki
lgtm https://codereview.chromium.org/470983002/diff/60001/ui/file_manager/gallery/js/gallery.js File ui/file_manager/gallery/js/gallery.js (right): https://codereview.chromium.org/470983002/diff/60001/ui/file_manager/gallery/js/gallery.js#newcode522 ui/file_manager/gallery/js/gallery.js:522: }.bind(this)); nit: remove bind https://codereview.chromium.org/470983002/diff/60001/ui/file_manager/gallery/js/gallery.js#newcode523 ui/file_manager/gallery/js/gallery.js:523: }.bind(this); nit: ...
6 years, 4 months ago (2014-08-15 07:08:12 UTC) #4
hirono
https://codereview.chromium.org/470983002/diff/60001/ui/file_manager/gallery/js/gallery.js File ui/file_manager/gallery/js/gallery.js (right): https://codereview.chromium.org/470983002/diff/60001/ui/file_manager/gallery/js/gallery.js#newcode522 ui/file_manager/gallery/js/gallery.js:522: }.bind(this)); On 2014/08/15 07:08:12, yoshiki wrote: > nit: remove ...
6 years, 4 months ago (2014-08-15 07:14:33 UTC) #5
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 4 months ago (2014-08-15 07:14:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/470983002/80001
6 years, 4 months ago (2014-08-15 07:16:26 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 17:15:30 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (80001) as 289922

Powered by Google App Engine
This is Rietveld 408576698