content/renderer/render_thread_impl.cc - Issue 470973002: gpu: Remove WebGraphicsContext3D::makeContextCurrent()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_thread_impl.cc

Issue 470973002: gpu: Remove WebGraphicsContext3D::makeContextCurrent() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove WebGraphicsContext3D::makeContextCurrent() Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/in_process/synchronous_compositor_factory_impl.cc ('K') | « content/renderer/media/android/webmediaplayer_android.cc ('k') | content/renderer/renderer_webkitplatformsupport_impl.cc » ('j') | content/renderer/renderer_webkitplatformsupport_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_thread_impl.cc

diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc

index 3975856b9b0a14cfd62120fd9ddbb8ec296a849c..930d476afda8fa9d79d03ba4ba7c59b357e7f8dc 100644

--- a/content/renderer/render_thread_impl.cc

+++ b/content/renderer/render_thread_impl.cc

@@ -1177,10 +1177,10 @@ RenderThreadImpl::SharedMainThreadContextProvider() {

shared_main_thread_contexts_ = ContextProviderCommandBuffer::Create(

CreateOffscreenContext3d(), "Offscreen-MainThread");

}

+ if (shared_main_thread_contexts_ &&

+ !shared_main_thread_contexts_->BindToCurrentThread())

dshwang 2014/08/15 14:54:01 BindToCurrentThread() should be called one time wh

danakj 2014/08/15 15:28:44 This seems like a separate change, can you do this

dshwang 2014/08/15 16:02:32 Ok, I'll separate it on another CL.

+ shared_main_thread_contexts_ = NULL;

}

- if (shared_main_thread_contexts_ &&

- !shared_main_thread_contexts_->BindToCurrentThread())

- shared_main_thread_contexts_ = NULL;

return shared_main_thread_contexts_;

}