Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: webkit/common/gpu/webgraphicscontext3d_impl.h

Issue 470973002: gpu: Remove WebGraphicsContext3D::makeContextCurrent() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fix in unittests Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/common/gpu/webgraphicscontext3d_impl.h
diff --git a/webkit/common/gpu/webgraphicscontext3d_impl.h b/webkit/common/gpu/webgraphicscontext3d_impl.h
index 5cb055db5f841ebcf7c4978b28828697370b0330..9097b8f5adfb8d1691097895c9a6aa8db40a997b 100644
--- a/webkit/common/gpu/webgraphicscontext3d_impl.h
+++ b/webkit/common/gpu/webgraphicscontext3d_impl.h
@@ -46,6 +46,13 @@ class WebGraphicsContext3DErrorMessageCallback;
class WEBKIT_GPU_EXPORT WebGraphicsContext3DImpl
: public NON_EXPORTED_BASE(blink::WebGraphicsContext3D) {
public:
+ virtual ~WebGraphicsContext3DImpl();
+
+ // Must be called before any of the following methods. Permanently binds to
+ // the first calling thread. Returns false if the graphics context fails to
+ // initialize. Do not call from more than one thread.
+ virtual bool InitializeOnCurrentThread() = 0;
+
//----------------------------------------------------------------------
// WebGraphicsContext3D methods
@@ -570,7 +577,6 @@ class WEBKIT_GPU_EXPORT WebGraphicsContext3DImpl
friend class WebGraphicsContext3DErrorMessageCallback;
WebGraphicsContext3DImpl();
- virtual ~WebGraphicsContext3DImpl();
::gpu::gles2::GLES2ImplementationErrorMessageCallback*
getErrorMessageCallback();
« no previous file with comments | « webkit/common/gpu/grcontext_for_webgraphicscontext3d.cc ('k') | webkit/common/gpu/webgraphicscontext3d_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698