content/shell/renderer/test_runner/TestPlugin.cpp - Issue 470973002: gpu: Remove WebGraphicsContext3D::makeContextCurrent()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/TestPlugin.cpp

Issue 470973002: gpu: Remove WebGraphicsContext3D::makeContextCurrent() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make the interaction between the if and the #if readable Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/renderer_webkitplatformsupport_impl.cc ('K') | « content/renderer/renderer_webkitplatformsupport_impl.cc ('k') | webkit/common/gpu/context_provider_in_process.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/test_runner/TestPlugin.cpp

diff --git a/content/shell/renderer/test_runner/TestPlugin.cpp b/content/shell/renderer/test_runner/TestPlugin.cpp

index cb33167043671119c532df2d5330a03fe0bf0136..b7bcfd3b1d5fd2d8031ed565e61261a5072ff171 100644

--- a/content/shell/renderer/test_runner/TestPlugin.cpp

+++ b/content/shell/renderer/test_runner/TestPlugin.cpp

@@ -192,10 +192,6 @@ bool TestPlugin::initialize(WebPluginContainer* container)

{

WebGraphicsContext3D::Attributes attrs;

m_context = Platform::current()->createOffscreenGraphicsContext3D(attrs);

- if (m_context && !m_context->makeContextCurrent()) {

- delete m_context;

- m_context = 0;

- }

if (!initScene())

return false;