webkit/common/gpu/webgraphicscontext3d_impl.cc - Issue 470973002: gpu: Remove WebGraphicsContext3D::makeContextCurrent()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/common/gpu/webgraphicscontext3d_impl.cc

Issue 470973002: gpu: Remove WebGraphicsContext3D::makeContextCurrent() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use scoped_ptr and remove unrelated changes. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webkit/common/gpu/webgraphicscontext3d_impl.h ('K') | « webkit/common/gpu/webgraphicscontext3d_impl.h ('k') | webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h » ('j') | webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/common/gpu/webgraphicscontext3d_impl.cc

diff --git a/webkit/common/gpu/webgraphicscontext3d_impl.cc b/webkit/common/gpu/webgraphicscontext3d_impl.cc

index abf9d954b8c5c71cb13cd5f1ec611cf6f85cd6b1..d8fd01897e5c1b7c7ba6ff08aebf0dbf04964032 100644

--- a/webkit/common/gpu/webgraphicscontext3d_impl.cc

+++ b/webkit/common/gpu/webgraphicscontext3d_impl.cc

@@ -170,6 +170,10 @@ void WebGraphicsContext3DImpl::synthesizeGLError(WGC3Denum error) {

}

+bool WebGraphicsContext3DImpl::makeContextCurrent() {

+ return true;

uint32_t WebGraphicsContext3DImpl::lastFlushID() {

return flush_id_;

}

@@ -937,7 +941,6 @@ DELEGATE_TO_GL_5(renderbufferStorageMultisampleEXT,

WGC3Denum, WGC3Dsizei, WGC3Dsizei)

GrGLInterface* WebGraphicsContext3DImpl::createGrGLInterface() {

- makeContextCurrent();

return skia_bindings::CreateCommandBufferSkiaGLBinding();

}