content/renderer/media/android/webmediaplayer_android.cc - Issue 470973002: gpu: Remove WebGraphicsContext3D::makeContextCurrent()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.cc

Issue 470973002: gpu: Remove WebGraphicsContext3D::makeContextCurrent() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use scoped_ptr and remove unrelated changes. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc ('K') | « content/renderer/android/synchronous_compositor_factory.h ('k') | content/renderer/renderer_webkitplatformsupport_impl.cc » ('j') | content/renderer/renderer_webkitplatformsupport_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/android/webmediaplayer_android.cc

diff --git a/content/renderer/media/android/webmediaplayer_android.cc b/content/renderer/media/android/webmediaplayer_android.cc

index 930ea6d6a92026e47f37e4265f49f647885ba1cd..cf61001bce36dc2e08aec1f21fddd83ee0b5e7b6 100644

--- a/content/renderer/media/android/webmediaplayer_android.cc

+++ b/content/renderer/media/android/webmediaplayer_android.cc

@@ -521,7 +521,7 @@ void WebMediaPlayerAndroid::paint(blink::WebCanvas* canvas,

if (!provider)

return;

blink::WebGraphicsContext3D* context3D = provider->context3d();

- if (!context3D || !context3D->makeContextCurrent())

+ if (!context3D)

return;

// Copy video texture into a RGBA texture based bitmap first as video texture