content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc - Issue 470973002: gpu: Remove WebGraphicsContext3D::makeContextCurrent()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

Issue 470973002: gpu: Remove WebGraphicsContext3D::makeContextCurrent() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use scoped_ptr and remove unrelated changes. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h ('k') | content/renderer/android/synchronous_compositor_factory.h » ('j') | content/renderer/renderer_webkitplatformsupport_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

index 21ba2a6c198f70c38f5bbdda4b6f099dd7f1173e..2b551b90c91235d028d87b4f244b8aae9f57a15d 100644

--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

@@ -296,12 +296,11 @@ bool WebGraphicsContext3DCommandBufferImpl::CreateContext(bool onscreen) {

return true;

}

-bool WebGraphicsContext3DCommandBufferImpl::makeContextCurrent() {

+bool WebGraphicsContext3DCommandBufferImpl::BindToCurrentThread() {

if (!MaybeInitializeGL()) {

DLOG(ERROR) << "Failed to initialize context.";

return false;

}

- gles2::SetGLContext(GetGLInterface());

if (gpu::error::IsError(command_buffer_->GetLastError())) {

LOG(ERROR) << "Context dead on arrival. Last error: "

<< command_buffer_->GetLastError();