gpu: Remove WebGraphicsContext3D::makeContextCurrent()

webkit/common/gpu/webgraphicscontext3d_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_COMMON_GPU_WEBGRAPHICSCONTEXT3D_IMPL_H_
 #define WEBKIT_COMMON_GPU_WEBGRAPHICSCONTEXT3D_IMPL_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 28 matching lines @@
 using blink::WGC3Dsizeiptr;
 
 namespace webkit {
 namespace gpu {
 
 class WebGraphicsContext3DErrorMessageCallback;
 
 class WEBKIT_GPU_EXPORT WebGraphicsContext3DImpl
     : public NON_EXPORTED_BASE(blink::WebGraphicsContext3D) {
  public:
+  virtual ~WebGraphicsContext3DImpl();
+
+  // Must be called after initialize() and before any of the following methods.
+  // Permanently binds to the first calling thread. Returns false if the
+  // graphics context fails to create. Do not call from more than one thread.
+  virtual bool BindToCurrentThread() = 0;

[piman, 2014/08/15 17:47:34]

nit: There's no initialize() method any more. This does initialization, I think
we should call it as such... Initialize() or something. Maybe
InitializeOnCurrentThread() if we want to convey the thread constraints.

+
   //----------------------------------------------------------------------
   // WebGraphicsContext3D methods
 
+  // TODO(dshwang): remove it.
+  virtual bool makeContextCurrent();
   virtual uint32_t lastFlushID();
 
   virtual unsigned int insertSyncPoint();
   virtual void waitSyncPoint(unsigned int sync_point);
 
   virtual void loseContextCHROMIUM(WGC3Denum current, WGC3Denum other);
 
   virtual void reshapeWithScaleFactor(
       int width, int height, float scale_factor);
 
@@ skipping 501 matching lines @@
   // Convert WebGL context creation attributes into command buffer / EGL size
   // requests.
   static void ConvertAttributes(
       const blink::WebGraphicsContext3D::Attributes& attributes,
       ::gpu::gles2::ContextCreationAttribHelper* output_attribs);
 
  protected:
   friend class WebGraphicsContext3DErrorMessageCallback;
 
   WebGraphicsContext3DImpl();
-  virtual ~WebGraphicsContext3DImpl();
 
   ::gpu::gles2::GLES2ImplementationErrorMessageCallback*
       getErrorMessageCallback();
   virtual void OnErrorMessage(const std::string& message, int id);
 
   void setGLInterface(::gpu::gles2::GLES2Interface* gl) {
     gl_ = gl;
   }
 
   bool initialized_;
@@ skipping 12 matching lines @@
 
   ::gpu::gles2::GLES2Interface* gl_;
   bool lose_context_when_out_of_memory_;
   uint32_t flush_id_;
 };
 
 }  // namespace gpu
 }  // namespace webkit
 
 #endif  // WEBKIT_COMMON_GPU_WEBGRAPHICSCONTEXT3D_IMPL_H_