Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: ui/gfx/platform_font_ios.mm

Issue 470923005: Reland: Update iOS deployment target to 7.0 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nil font handling Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | ui/gfx/text_utils_ios.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/platform_font_ios.mm
diff --git a/ui/gfx/platform_font_ios.mm b/ui/gfx/platform_font_ios.mm
index 03f5ddbe75a6e986c4f8d2770369d96a60ba53fe..0fd824fcd6373d754d37f6a2c0500d84f310d442 100644
--- a/ui/gfx/platform_font_ios.mm
+++ b/ui/gfx/platform_font_ios.mm
@@ -6,6 +6,8 @@
#import <UIKit/UIKit.h>
+#include <cmath>
+
#include "base/basictypes.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
@@ -110,7 +112,12 @@ void PlatformFontIOS::CalculateMetrics() {
height_ = font.lineHeight;
ascent_ = font.ascender;
cap_height_ = font.capHeight;
- average_width_ = [@"x" sizeWithFont:font].width;
+ if (font) {
+ NSDictionary* attributes = @{ NSFontAttributeName : font };
+ average_width_ = std::ceil([@"x" sizeWithAttributes:attributes].width);
+ } else {
+ average_width_ = 0;
+ }
}
////////////////////////////////////////////////////////////////////////////////
« no previous file with comments | « build/common.gypi ('k') | ui/gfx/text_utils_ios.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698