Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 470923004: DevTools: DevToolsAgentHost::Close/GetURL for service workers (Closed)

Created:
6 years, 4 months ago by vkuzkokov
Modified:
6 years, 4 months ago
Reviewers:
dgozman, pfeldman, yurys, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, vsevik, tzik, horo+watch_chromium.org, jam, serviceworker-reviews, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, nhiroki, devtools-reviews_chromium.org, kinuko+serviceworker, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: DevToolsAgentHost::Close/GetURL for service workers These are changes to EmbeddedWorkerInstance required to make DevToolsAgentHost::Close and GetURL work which are about to be added in crrev.com/459403002 BUG=389454 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290275

Patch Set 1 #

Patch Set 2 : Fixed crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -16 lines) Patch
M content/browser/devtools/embedded_worker_devtools_agent_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_agent_host.cc View 2 chunks +49 lines, -0 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_manager.h View 2 chunks +16 lines, -6 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_manager.cc View 1 chunk +36 lines, -8 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 1 4 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
vkuzkokov
6 years, 4 months ago (2014-08-14 12:41:49 UTC) #1
yurys
lgtm
6 years, 4 months ago (2014-08-14 13:01:49 UTC) #2
horo
lgtm
6 years, 4 months ago (2014-08-14 14:05:44 UTC) #3
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 4 months ago (2014-08-14 14:06:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/470923004/1
6 years, 4 months ago (2014-08-14 14:08:19 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-14 18:04:26 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 20:00:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/1819)
6 years, 4 months ago (2014-08-14 20:00:43 UTC) #8
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 4 months ago (2014-08-18 14:04:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/470923004/20001
6 years, 4 months ago (2014-08-18 14:05:09 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 17:14:08 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 290275

Powered by Google App Engine
This is Rietveld 408576698