Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: Source/core/css/parser/CSSParserValues.cpp

Issue 470903003: Remove CSSParserValue::createCSSValue and unused callers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@pp4
Patch Set: fix forward decl Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/parser/CSSParserValues.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSParserValues.cpp
diff --git a/Source/core/css/parser/CSSParserValues.cpp b/Source/core/css/parser/CSSParserValues.cpp
index dc5ca76b8493afa4c30d5138dc062a6d8a07b5df..565112bf85c75f19340b3bf76dbb64f59e803d67 100644
--- a/Source/core/css/parser/CSSParserValues.cpp
+++ b/Source/core/css/parser/CSSParserValues.cpp
@@ -68,84 +68,6 @@ void CSSParserValueList::stealValues(CSSParserValueList& valueList)
valueList.clearAndLeakValues();
}
-PassRefPtrWillBeRawPtr<CSSValue> CSSParserValue::createCSSValue()
-{
- if (id)
- return CSSPrimitiveValue::createIdentifier(id);
-
- if (unit == CSSParserValue::Operator)
- return CSSPrimitiveValue::createParserOperator(iValue);
- if (unit == CSSParserValue::Function)
- return CSSFunctionValue::create(function);
- if (unit == CSSParserValue::ValueList)
- return CSSValueList::createFromParserValueList(valueList);
- if (unit >= CSSParserValue::Q_EMS)
- return CSSPrimitiveValue::createAllowingMarginQuirk(fValue, CSSPrimitiveValue::CSS_EMS);
-
- CSSPrimitiveValue::UnitType primitiveUnit = static_cast<CSSPrimitiveValue::UnitType>(unit);
- switch (primitiveUnit) {
- case CSSPrimitiveValue::CSS_IDENT:
- case CSSPrimitiveValue::CSS_PROPERTY_ID:
- case CSSPrimitiveValue::CSS_VALUE_ID:
- return CSSPrimitiveValue::create(string, CSSPrimitiveValue::CSS_PARSER_IDENTIFIER);
- case CSSPrimitiveValue::CSS_NUMBER:
- return CSSPrimitiveValue::create(fValue, isInt ? CSSPrimitiveValue::CSS_PARSER_INTEGER : CSSPrimitiveValue::CSS_NUMBER);
- case CSSPrimitiveValue::CSS_STRING:
- case CSSPrimitiveValue::CSS_URI:
- case CSSPrimitiveValue::CSS_PARSER_HEXCOLOR:
- return CSSPrimitiveValue::create(string, primitiveUnit);
- case CSSPrimitiveValue::CSS_PERCENTAGE:
- case CSSPrimitiveValue::CSS_EMS:
- case CSSPrimitiveValue::CSS_EXS:
- case CSSPrimitiveValue::CSS_PX:
- case CSSPrimitiveValue::CSS_CM:
- case CSSPrimitiveValue::CSS_MM:
- case CSSPrimitiveValue::CSS_IN:
- case CSSPrimitiveValue::CSS_PT:
- case CSSPrimitiveValue::CSS_PC:
- case CSSPrimitiveValue::CSS_DEG:
- case CSSPrimitiveValue::CSS_RAD:
- case CSSPrimitiveValue::CSS_GRAD:
- case CSSPrimitiveValue::CSS_MS:
- case CSSPrimitiveValue::CSS_S:
- case CSSPrimitiveValue::CSS_HZ:
- case CSSPrimitiveValue::CSS_KHZ:
- case CSSPrimitiveValue::CSS_VW:
- case CSSPrimitiveValue::CSS_VH:
- case CSSPrimitiveValue::CSS_VMIN:
- case CSSPrimitiveValue::CSS_VMAX:
- case CSSPrimitiveValue::CSS_TURN:
- case CSSPrimitiveValue::CSS_REMS:
- case CSSPrimitiveValue::CSS_CHS:
- case CSSPrimitiveValue::CSS_FR:
- return CSSPrimitiveValue::create(fValue, primitiveUnit);
- case CSSPrimitiveValue::CSS_UNKNOWN:
- case CSSPrimitiveValue::CSS_DIMENSION:
- case CSSPrimitiveValue::CSS_ATTR:
- case CSSPrimitiveValue::CSS_COUNTER:
- case CSSPrimitiveValue::CSS_RECT:
- case CSSPrimitiveValue::CSS_RGBCOLOR:
- case CSSPrimitiveValue::CSS_DPPX:
- case CSSPrimitiveValue::CSS_DPI:
- case CSSPrimitiveValue::CSS_DPCM:
- case CSSPrimitiveValue::CSS_PAIR:
- case CSSPrimitiveValue::CSS_UNICODE_RANGE:
- case CSSPrimitiveValue::CSS_PARSER_INTEGER:
- case CSSPrimitiveValue::CSS_PARSER_IDENTIFIER:
- case CSSPrimitiveValue::CSS_PARSER_OPERATOR:
- case CSSPrimitiveValue::CSS_COUNTER_NAME:
- case CSSPrimitiveValue::CSS_SHAPE:
- case CSSPrimitiveValue::CSS_QUAD:
- case CSSPrimitiveValue::CSS_CALC:
- case CSSPrimitiveValue::CSS_CALC_PERCENTAGE_WITH_NUMBER:
- case CSSPrimitiveValue::CSS_CALC_PERCENTAGE_WITH_LENGTH:
- return nullptr;
- }
-
- ASSERT_NOT_REACHED();
- return nullptr;
-}
-
CSSParserSelector::CSSParserSelector()
: m_selector(adoptPtr(new CSSSelector()))
{
« no previous file with comments | « Source/core/css/parser/CSSParserValues.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698