Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 470803008: chromeos: Avoid a startup crash when powerd isn't running. (Closed)

Created:
6 years, 4 months ago by Daniel Erat
Modified:
6 years, 3 months ago
Reviewers:
Chris Masone, cmasone1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

chromeos: Avoid a startup crash when powerd isn't running. Introduced by r290692. BUG=406968 Committed: https://crrev.com/7c3c3e50256f9435369650f423a669a764381587 Cr-Commit-Position: refs/heads/master@{#291725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chromeos/dbus/power_manager_client.cc View 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Daniel Erat
6 years, 4 months ago (2014-08-25 17:28:56 UTC) #1
Chris Masone
lgtm
6 years, 4 months ago (2014-08-25 17:30:41 UTC) #2
Daniel Erat
The CQ bit was checked by derat@chromium.org
6 years, 4 months ago (2014-08-25 17:32:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/470803008/1
6 years, 4 months ago (2014-08-25 17:33:55 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-25 18:28:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as fd55d32d42fc0676469c2820813693f825f21f23
6 years, 4 months ago (2014-08-25 18:44:52 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:36:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c3c3e50256f9435369650f423a669a764381587
Cr-Commit-Position: refs/heads/master@{#291725}

Powered by Google App Engine
This is Rietveld 408576698