Issue 4708005: laptop-mode-tools: only log VERBOSE msgs to syslog when DEBUG is enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4708005: laptop-mode-tools: only log VERBOSE msgs to syslog when DEBUG is enabled (Closed)

Created:
10 years, 1 month ago by Sam Leffler

Modified:
9 years, 7 months ago

Reviewers:
Sameer Nanda

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/laptop-mode-tools.git@master

Visibility:
Public.

Description

laptop-mode-tools: only log VERBOSE msgs to syslog when DEBUG is enabled VERBOSE msgs are almost universally useless but were being sent through syslog where they were being tossed with our default config. This resulted in >600 context switches to just drop the log msgs. Avoid this overhead by making them condition on DEBUG. BUG=8087 TEST=sh -x /usr/sbin/laptop_mode auto force and notice tons of logger calls Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9b7ebd6

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	laptop-mode-tools_1.52/usr/sbin/laptop_mode	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sam Leffler

There appear to be lots of other low-hanging performance fruit in this stuff. I measured ...

10 years, 1 month ago (2010-11-10 00:40:29 UTC) #1

Sameer Nanda

10 years, 1 month ago (2010-11-10 18:57:51 UTC) #2

LGTM. 

We will likely migrate away from laptop mode tools medium term since we keep
running into limitations with it. If there are other low hanging fruits, I
wouldn't mind fixing them for the short term, though.

Expand Messages | Collapse Messages