Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 4708005: laptop-mode-tools: only log VERBOSE msgs to syslog when DEBUG is enabled (Closed)

Created:
8 years, 9 months ago by Sam Leffler
Modified:
8 years, 3 months ago
Reviewers:
Sameer Nanda
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

laptop-mode-tools: only log VERBOSE msgs to syslog when DEBUG is enabled VERBOSE msgs are almost universally useless but were being sent through syslog where they were being tossed with our default config. This resulted in >600 context switches to just drop the log msgs. Avoid this overhead by making them condition on DEBUG. BUG=8087 TEST=sh -x /usr/sbin/laptop_mode auto force and notice tons of logger calls Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9b7ebd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M laptop-mode-tools_1.52/usr/sbin/laptop_mode View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Sam Leffler
There appear to be lots of other low-hanging performance fruit in this stuff. I measured ...
8 years, 9 months ago (2010-11-10 00:40:29 UTC) #1
Sameer Nanda
8 years, 9 months ago (2010-11-10 18:57:51 UTC) #2
LGTM. 

We will likely migrate away from laptop mode tools medium term since we keep
running into limitations with it. If there are other low hanging fruits, I
wouldn't mind fixing them for the short term, though.

Powered by Google App Engine
This is Rietveld 408576698