Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 470753002: cc: Change Tile::tile_size_ from a Rect to a Size. (Closed)

Created:
6 years, 4 months ago by danakj
Modified:
6 years, 4 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman, reveman, vmpstr
Project:
chromium
Visibility:
Public.

Description

cc: Change Tile::tile_size_ from a Rect to a Size. Nothing sets or uses the position, its name suggests nothing will. R=enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M cc/resources/tile.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/tile.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
6 years, 4 months ago (2014-08-13 22:13:38 UTC) #1
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 4 months ago (2014-08-13 22:29:00 UTC) #2
enne (OOO)
lgtm
6 years, 4 months ago (2014-08-13 22:29:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/470753002/1
6 years, 4 months ago (2014-08-13 22:32:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 10:40:20 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 16:05:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 289607

Powered by Google App Engine
This is Rietveld 408576698