Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 47073009: Improve indexOf for one byte string receiver to work with other string classes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/bootstrap_natives.h ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl_test.cc
===================================================================
--- runtime/vm/dart_api_impl_test.cc (revision 29605)
+++ runtime/vm/dart_api_impl_test.cc (working copy)
@@ -7262,6 +7262,7 @@
str_data,
&ExternalStringDeoptimize_Finalize);
EXPECT_VALID(result);
+ EXPECT(Dart_IsExternalString(result));
Dart_ExitScope();
}
@@ -7405,4 +7406,33 @@
EXPECT_EQ(8, value);
}
+
+TEST_CASE(ExternalStringIndexOf) {
+ const char* kScriptChars =
+ "main(String pattern) {\n"
+ " var str = 'Hello World';\n"
+ " return str.indexOf(pattern);\n"
+ "}\n";
+ Dart_Handle lib =
+ TestCase::LoadTestScript(kScriptChars, NULL);
+
+ uint8_t data8[] = { 'W' };
+ Dart_Handle ext8 = Dart_NewExternalLatin1String(data8, ARRAY_SIZE(data8),
+ data8, NULL);
+ EXPECT_VALID(ext8);
+ EXPECT(Dart_IsString(ext8));
+ EXPECT(Dart_IsExternalString(ext8));
+
+ Dart_Handle dart_args[1];
+ dart_args[0] = ext8;
+ Dart_Handle result = Dart_Invoke(lib,
+ NewString("main"),
+ 1,
+ dart_args);
+ int64_t value = 0;
+ result = Dart_IntegerToInt64(result, &value);
+ EXPECT_VALID(result);
+ EXPECT_EQ(6, value);
+}
+
} // namespace dart
« no previous file with comments | « runtime/vm/bootstrap_natives.h ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698