Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 47073007: Bindings: Remove special cases for DOMStringList (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp
index c27ea5448cece057f325ed294073a641991572dc..3fbe00984dd660c787a1914903dc79dd83b1cba4 100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -3811,7 +3811,7 @@ static void overloadedMethod6Method(const v8::FunctionCallbackInfo<v8::Value>& i
return;
}
TestObj* imp = V8TestObject::toNative(info.Holder());
- V8TRYCATCH_VOID(RefPtr<DOMStringList>, listArg, toDOMStringList(info[0], info.GetIsolate()));
+ V8TRYCATCH_VOID(DOMStringList*, listArg, V8DOMStringList::HasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8DOMStringList::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0);
imp->overloadedMethod(listArg);
}
@@ -4136,7 +4136,7 @@ static void domStringListFunctionMethod(const v8::FunctionCallbackInfo<v8::Value
}
TestObj* imp = V8TestObject::toNative(info.Holder());
ExceptionState es(info.GetIsolate());
- V8TRYCATCH_VOID(RefPtr<DOMStringList>, values, toDOMStringList(info[0], info.GetIsolate()));
+ V8TRYCATCH_VOID(DOMStringList*, values, V8DOMStringList::HasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8DOMStringList::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0);
RefPtr<DOMStringList> result = imp->domStringListFunction(values, es);
if (es.throwIfNeeded())
return;
« no previous file with comments | « Source/bindings/tests/results/V8TestCallback.cpp ('k') | Source/bindings/tests/results/V8TestObjectPython.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698