Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: Source/bindings/tests/results/V8TestCallback.cpp

Issue 47073007: Bindings: Remove special cases for DOMStringList (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestCallback.h ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8TestCallback.cpp
diff --git a/Source/bindings/tests/results/V8TestCallback.cpp b/Source/bindings/tests/results/V8TestCallback.cpp
index 682055dec5f76a1bd8c7917b8eb52d4feace18b5..2fa19a6e6fb30ea2cf92e4b7db38cba2ba3412fb 100644
--- a/Source/bindings/tests/results/V8TestCallback.cpp
+++ b/Source/bindings/tests/results/V8TestCallback.cpp
@@ -21,7 +21,6 @@
#include "config.h"
#include "V8TestCallback.h"
-#include "V8DOMStringList.h"
#include "V8TestObject.h"
#include "bindings/v8/V8Binding.h"
#include "bindings/v8/V8Callback.h"
@@ -130,35 +129,6 @@ bool V8TestCallback::callbackWithTestObjectParam(TestObj* class2Param, const Str
return !invokeCallback(m_callback.newLocal(isolate), 2, argv, callbackReturnValue, executionContext(), isolate);
}
-bool V8TestCallback::callbackWithStringList(RefPtr<DOMStringList> listParam)
-{
- if (!canInvokeCallback())
- return true;
-
- v8::Isolate* isolate = v8::Isolate::GetCurrent();
- v8::HandleScope handleScope(isolate);
-
- v8::Handle<v8::Context> v8Context = toV8Context(executionContext(), m_world.get());
- if (v8Context.IsEmpty())
- return true;
-
- v8::Context::Scope scope(v8Context);
-
- v8::Handle<v8::Value> listParamHandle = toV8(listParam, v8::Handle<v8::Object>(), isolate);
- if (listParamHandle.IsEmpty()) {
- if (!isScriptControllerTerminating())
- CRASH();
- return true;
- }
-
- v8::Handle<v8::Value> argv[] = {
- listParamHandle
- };
-
- bool callbackReturnValue = false;
- return !invokeCallback(m_callback.newLocal(isolate), 1, argv, callbackReturnValue, executionContext(), isolate);
-}
-
bool V8TestCallback::callbackWithBoolean(bool boolParam)
{
if (!canInvokeCallback())
« no previous file with comments | « Source/bindings/tests/results/V8TestCallback.h ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698