Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: Source/bindings/tests/results/V8TestObjectPython.cpp

Issue 47073007: Bindings: Remove special cases for DOMStringList (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestObjectPython.cpp
diff --git a/Source/bindings/tests/results/V8TestObjectPython.cpp b/Source/bindings/tests/results/V8TestObjectPython.cpp
index 754a545e8e35a74b560aaf1c676d1610888aa3fd..36146ac15936d476ba52adf743a39ba938f29068 100644
--- a/Source/bindings/tests/results/V8TestObjectPython.cpp
+++ b/Source/bindings/tests/results/V8TestObjectPython.cpp
@@ -711,7 +711,7 @@ static void domStringListAttributeAttributeGetterCallback(v8::Local<v8::String>
static void domStringListAttributeAttributeSetter(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<void>& info)
{
TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
- V8TRYCATCH_VOID(RefPtr<DOMStringList>, cppValue, toDOMStringList(jsValue, info.GetIsolate()));
+ V8TRYCATCH_VOID(DOMStringList*, cppValue, V8DOMStringList::HasInstance(jsValue, info.GetIsolate(), worldType(info.GetIsolate())) ? V8DOMStringList::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
imp->setDomStringListAttribute(WTF::getPtr(cppValue));
}
@@ -4242,7 +4242,7 @@ static void voidMethodDOMStringListArgMethod(const v8::FunctionCallbackInfo<v8::
return;
}
TestObjectPython* imp = V8TestObjectPython::toNative(args.Holder());
- V8TRYCATCH_VOID(RefPtr<DOMStringList>, domStringListArg, toDOMStringList(args[0], args.GetIsolate()));
+ V8TRYCATCH_VOID(DOMStringList*, domStringListArg, V8DOMStringList::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate())) ? V8DOMStringList::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0);
imp->voidMethodDOMStringListArg(domStringListArg);
}

Powered by Google App Engine
This is Rietveld 408576698