GetDisplayForScreen cleanup

GetDisplayForScreen cleanup

Doing the primary display check inside the GetDisplayForScreen function
so that the other utility functions can stop guessing about whether
the display they return is primary or not.

BUG=
R=Nico

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232054

[Nico, 2013-10-30 17:06:19]

lgtm

https://codereview.chromium.org/47073006/diff/1/ui/gfx/screen_mac.mm
File ui/gfx/screen_mac.mm (right):

https://codereview.chromium.org/47073006/diff/1/ui/gfx/screen_mac.mm#newcode54
ui/gfx/screen_mac.mm:54: if (screen == primary) {
this should probably be [screen isEqual:primary] (add some local debug logging
to make sure this doesn't change behavior in practice if you change this)

[Dominik Röttsches, 2013-10-30 17:32:16]

On 2013/10/30 17:06:19, Nico wrote:
> lgtm
> 
> https://codereview.chromium.org/47073006/diff/1/ui/gfx/screen_mac.mm
> File ui/gfx/screen_mac.mm (right):
> 
> https://codereview.chromium.org/47073006/diff/1/ui/gfx/screen_mac.mm#newcode54
> ui/gfx/screen_mac.mm:54: if (screen == primary) {
> this should probably be [screen isEqual:primary] (add some local debug logging
> to make sure this doesn't change behavior in practice if you change this)

Thanks for the review - I checked the identical comparison behaviour separately.

[commit-bot: I haz the power, 2013-10-30 17:34:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/47073006/5...

[commit-bot: I haz the power, 2013-10-30 20:10:07]

Retried try job too often on win_rel for step(s) chrome_frame_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-10-31 08:34:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/47073006/5...

[commit-bot: I haz the power, 2013-10-31 09:16:57]

Change committed as 232054