Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: pkg/analysis_server/test/integration/protocol_matchers.dart

Issue 470723003: Proposal for RefactoringMethodParameter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add the 'kind' and 'parameters' fields. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/protocol_matchers.dart
diff --git a/pkg/analysis_server/test/integration/protocol_matchers.dart b/pkg/analysis_server/test/integration/protocol_matchers.dart
index a87495b86c5497e61759d93ab7347a30466438e4..241b704f81f529dc29956cdeee2b9cf86665d21f 100644
--- a/pkg/analysis_server/test/integration/protocol_matchers.dart
+++ b/pkg/analysis_server/test/integration/protocol_matchers.dart
@@ -1486,20 +1486,6 @@ final Matcher isOverriddenMember = new MatchesJsonObject(
});
/**
- * Parameter
- *
- * {
- * "type": String
- * "name": String
- * }
- */
-final Matcher isParameter = new MatchesJsonObject(
- "Parameter", {
- "type": isString,
- "name": isString
- });
-
-/**
* Position
*
* {
@@ -1537,6 +1523,42 @@ final Matcher isRefactoringKind = new MatchesEnum("RefactoringKind", [
]);
/**
+ * RefactoringMethodParameter
+ *
+ * {
+ * "id": optional String
+ * "kind": RefactoringMethodParameterKind
+ * "type": String
+ * "name": String
+ * "parameters": optional String
+ * }
+ */
+final Matcher isRefactoringMethodParameter = new MatchesJsonObject(
+ "RefactoringMethodParameter", {
+ "kind": isRefactoringMethodParameterKind,
+ "type": isString,
+ "name": isString
+ }, optionalFields: {
+ "id": isString,
+ "parameters": isString
+ });
+
+/**
+ * RefactoringMethodParameterKind
+ *
+ * enum {
+ * REQUIRED
+ * POSITIONAL
+ * NAMED
+ * }
+ */
+final Matcher isRefactoringMethodParameterKind = new MatchesEnum("RefactoringMethodParameterKind", [
+ "REQUIRED",
+ "POSITIONAL",
+ "NAMED"
+]);
+
+/**
* RefactoringProblem
*
* {
@@ -1771,7 +1793,7 @@ final Matcher isExtractLocalVariableOptions = new MatchesJsonObject(
* "returnType": String
* "names": List<String>
* "canCreateGetter": bool
- * "parameters": List<Parameter>
+ * "parameters": List<RefactoringMethodParameter>
* "occurrences": int
* "offsets": List<int>
* "lengths": List<int>
@@ -1784,7 +1806,7 @@ final Matcher isExtractMethodFeedback = new MatchesJsonObject(
"returnType": isString,
"names": isListOf(isString),
"canCreateGetter": isBool,
- "parameters": isListOf(isParameter),
+ "parameters": isListOf(isRefactoringMethodParameter),
"occurrences": isInt,
"offsets": isListOf(isInt),
"lengths": isListOf(isInt)
@@ -1797,7 +1819,7 @@ final Matcher isExtractMethodFeedback = new MatchesJsonObject(
* "returnType": String
* "createGetter": bool
* "name": String
- * "parameters": List<Parameter>
+ * "parameters": List<RefactoringMethodParameter>
* "extractAll": bool
* }
*/
@@ -1806,7 +1828,7 @@ final Matcher isExtractMethodOptions = new MatchesJsonObject(
"returnType": isString,
"createGetter": isBool,
"name": isString,
- "parameters": isListOf(isParameter),
+ "parameters": isListOf(isRefactoringMethodParameter),
"extractAll": isBool
});

Powered by Google App Engine
This is Rietveld 408576698