Proposal for RefactoringMethodParameter.

pkg/analysis_server/tool/spec/spec_input.html

Index: pkg/analysis_server/tool/spec/spec_input.html
diff --git a/pkg/analysis_server/tool/spec/spec_input.html b/pkg/analysis_server/tool/spec/spec_input.html
index 1f307600c7fac2cc7f0526b899a296dad8037915..320ac0e47b56a9af5ecbca26098743ab886fb6f8 100644
--- a/pkg/analysis_server/tool/spec/spec_input.html
+++ b/pkg/analysis_server/tool/spec/spec_input.html
@@ -2418,25 +2418,6 @@
           </field>
         </object>
       </type>
-      <type name="Parameter">
-        <p>
-          A description of a parameter.
-        </p>
-        <object>
-          <field name="type">
-            <ref>String</ref>
-            <p>
-              The type that should be given to the parameter.
-            </p>
-          </field>
-          <field name="name">
-            <ref>String</ref>
-            <p>
-              The name that should be given to the parameter.
-            </p>
-          </field>
-        </object>
-      </type>
       <type name="Position">
         <p>
           A position within a file.
@@ -2471,6 +2452,32 @@
           <value><code>RENAME</code></value>
         </enum>
       </type>
+      <type name="RefactoringMethodParameter">

[Brian Wilkerson, 2014/08/13 23:14:29]

Do we need to allow parameters to be marked as 'optional' or 'named'?

[scheglov, 2014/08/14 02:35:28]

Acknowledged.
I will add the "kind" field.

+        <p>
+          A description of a parameter in a method refactoring.
+        </p>
+        <object>
+          <field name="id" optional="true">
+            <ref>String</ref>
+            <p>
+              The unique identifier of the parameter.

[Brian Wilkerson, 2014/08/13 23:14:29]

Probably need to specify that the id must match the id returned for a proposed
parameter unless it's being added.

[scheglov, 2014/08/14 02:35:28]

I will document it at the place where client provides these parameters.

+              Clients may omit this field for the parameters they want to add.
+            </p>
+          </field>
+          <field name="type">

[Paul Berry, 2014/08/13 23:59:08]

I think we need something more than just a String for the type, since we need to
support parameters whose type is a function, e.g. the parameter "callback" in
the method "foo" below:

  foo(ReturnType callback(int arg1, int arg2)) {
  }

[scheglov, 2014/08/14 02:35:28]

I will add the "parameters" field as in Element.

+            <ref>String</ref>
+            <p>
+              The type that should be given to the parameter.
+            </p>
+          </field>
+          <field name="name">
+            <ref>String</ref>
+            <p>
+              The name that should be given to the parameter.
+            </p>
+          </field>
+        </object>
+      </type>
       <type name="RefactoringProblem">
         <p>
           A description of a problem related to a refactoring.
@@ -2897,7 +2904,7 @@
             </p>
           </field>
           <field name="parameters">
-            <list><ref>Parameter</ref></list>
+            <list><ref>RefactoringMethodParameter</ref></list>
             <p>
               The proposed parameters for the method.
             </p>
@@ -2949,9 +2956,12 @@
             </p>
           </field>
           <field name="parameters">
-            <list><ref>Parameter</ref></list>
+            <list><ref>RefactoringMethodParameter</ref></list>
             <p>
               The parameters that should be defined for the method.
+              Clients may change order of proposed parameters, add new ones

[Brian Wilkerson, 2014/08/13 23:14:29]

"order" --> "the order"

[scheglov, 2014/08/14 02:35:28]

Done.

+              or omit some parameters (corresponding parameters will not be
+              generated).
             </p>
           </field>
           <field name="extractAll">