Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: pkg/analysis_server/tool/spec/spec_input.html

Issue 470723003: Proposal for RefactoringMethodParameter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add the 'kind' and 'parameters' fields. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/analysis_server/test/integration/protocol_matchers.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <meta charset="UTF-8"/> 3 <meta charset="UTF-8"/>
4 <title>Analysis Server API Specification</title> 4 <title>Analysis Server API Specification</title>
5 </head> 5 </head>
6 <body> 6 <body>
7 <h1>Analysis Server API Specification</h1> 7 <h1>Analysis Server API Specification</h1>
8 <h1 style="color:#999999">WORKING DRAFT - Version <version>0.3</version></h1 > 8 <h1 style="color:#999999">WORKING DRAFT - Version <version>0.3</version></h1 >
9 <p> 9 <p>
10 This document contains a specification of the API provided by 10 This document contains a specification of the API provided by
(...skipping 2400 matching lines...) Expand 10 before | Expand all | Expand 10 after
2411 </p> 2411 </p>
2412 </field> 2412 </field>
2413 <field name="className"> 2413 <field name="className">
2414 <ref>String</ref> 2414 <ref>String</ref>
2415 <p> 2415 <p>
2416 The name of the class in which the member is defined. 2416 The name of the class in which the member is defined.
2417 </p> 2417 </p>
2418 </field> 2418 </field>
2419 </object> 2419 </object>
2420 </type> 2420 </type>
2421 <type name="Parameter">
2422 <p>
2423 A description of a parameter.
2424 </p>
2425 <object>
2426 <field name="type">
2427 <ref>String</ref>
2428 <p>
2429 The type that should be given to the parameter.
2430 </p>
2431 </field>
2432 <field name="name">
2433 <ref>String</ref>
2434 <p>
2435 The name that should be given to the parameter.
2436 </p>
2437 </field>
2438 </object>
2439 </type>
2440 <type name="Position"> 2421 <type name="Position">
2441 <p> 2422 <p>
2442 A position within a file. 2423 A position within a file.
2443 </p> 2424 </p>
2444 <object> 2425 <object>
2445 <field name="file"> 2426 <field name="file">
2446 <ref>FilePath</ref> 2427 <ref>FilePath</ref>
2447 <p> 2428 <p>
2448 The file containing the position. 2429 The file containing the position.
2449 </p> 2430 </p>
(...skipping 14 matching lines...) Expand all
2464 <enum> 2445 <enum>
2465 <value><code>CONVERT_GETTER_TO_METHOD</code></value> 2446 <value><code>CONVERT_GETTER_TO_METHOD</code></value>
2466 <value><code>CONVERT_METHOD_TO_GETTER</code></value> 2447 <value><code>CONVERT_METHOD_TO_GETTER</code></value>
2467 <value><code>EXTRACT_LOCAL_VARIABLE</code></value> 2448 <value><code>EXTRACT_LOCAL_VARIABLE</code></value>
2468 <value><code>EXTRACT_METHOD</code></value> 2449 <value><code>EXTRACT_METHOD</code></value>
2469 <value><code>INLINE_LOCAL_VARIABLE</code></value> 2450 <value><code>INLINE_LOCAL_VARIABLE</code></value>
2470 <value><code>INLINE_METHOD</code></value> 2451 <value><code>INLINE_METHOD</code></value>
2471 <value><code>RENAME</code></value> 2452 <value><code>RENAME</code></value>
2472 </enum> 2453 </enum>
2473 </type> 2454 </type>
2455 <type name="RefactoringMethodParameter">
2456 <p>
2457 A description of a parameter in a method refactoring.
2458 </p>
2459 <object>
2460 <field name="id" optional="true">
2461 <ref>String</ref>
2462 <p>
2463 The unique identifier of the parameter.
2464 Clients may omit this field for the parameters they want to add.
2465 </p>
2466 </field>
2467 <field name="kind">
2468 <ref>RefactoringMethodParameterKind</ref>
2469 <p>
2470 The type that should be given to the parameter, or the return type
2471 of the parameter's function type.
2472 </p>
2473 </field>
2474 <field name="type">
2475 <ref>String</ref>
2476 <p>
2477 The kind of the parameter.
Brian Wilkerson 2014/08/14 14:38:08 I think the comments for "kind" and "type" got rev
scheglov 2014/08/14 15:54:40 Ouch! Fixed.
2478 </p>
2479 </field>
2480 <field name="name">
2481 <ref>String</ref>
2482 <p>
2483 The name that should be given to the parameter.
2484 </p>
2485 </field>
2486 <field name="parameters" optional="true">
2487 <ref>String</ref>
Brian Wilkerson 2014/08/14 14:38:08 Do we want this to be List<RefactoringMethodParame
scheglov 2014/08/14 15:54:40 We're not going to change them, so we don't need t
2488 <p>
2489 The parameter list of the parameter's function type.
2490 If the parameter is not of a function type, this field will
2491 not be defined. If the function type has zero parameters, this
2492 field will have a value of "()".
2493 </p>
2494 </field>
2495 </object>
2496 </type>
2497 <type name="RefactoringMethodParameterKind">
2498 <p>
2499 An enumeration of the kinds of parameters.
2500 </p>
2501 <enum>
2502 <value><code>REQUIRED</code></value>
2503 <value><code>POSITIONAL</code></value>
2504 <value><code>NAMED</code></value>
2505 </enum>
2506 </type>
2474 <type name="RefactoringProblem"> 2507 <type name="RefactoringProblem">
2475 <p> 2508 <p>
2476 A description of a problem related to a refactoring. 2509 A description of a problem related to a refactoring.
2477 </p> 2510 </p>
2478 <object> 2511 <object>
2479 <field name="severity"> 2512 <field name="severity">
2480 <ref>RefactoringProblemSeverity</ref> 2513 <ref>RefactoringProblemSeverity</ref>
2481 <p> 2514 <p>
2482 The severity of the problem being represented. 2515 The severity of the problem being represented.
2483 </p> 2516 </p>
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
2890 The proposed names for the method. 2923 The proposed names for the method.
2891 </p> 2924 </p>
2892 </field> 2925 </field>
2893 <field name="canCreateGetter"> 2926 <field name="canCreateGetter">
2894 <ref>bool</ref> 2927 <ref>bool</ref>
2895 <p> 2928 <p>
2896 True if a getter could be created rather than a method. 2929 True if a getter could be created rather than a method.
2897 </p> 2930 </p>
2898 </field> 2931 </field>
2899 <field name="parameters"> 2932 <field name="parameters">
2900 <list><ref>Parameter</ref></list> 2933 <list><ref>RefactoringMethodParameter</ref></list>
2901 <p> 2934 <p>
2902 The proposed parameters for the method. 2935 The proposed parameters for the method.
2903 </p> 2936 </p>
2904 </field> 2937 </field>
2905 <field name="occurrences"> 2938 <field name="occurrences">
2906 <ref>int</ref> 2939 <ref>int</ref>
2907 <p> 2940 <p>
2908 The number of times the expression or statements occurs. 2941 The number of times the expression or statements occurs.
2909 </p> 2942 </p>
2910 </field> 2943 </field>
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
2942 list of parameters is non-empty. 2975 list of parameters is non-empty.
2943 </p> 2976 </p>
2944 </field> 2977 </field>
2945 <field name="name"> 2978 <field name="name">
2946 <ref>String</ref> 2979 <ref>String</ref>
2947 <p> 2980 <p>
2948 The name that the method should be given. 2981 The name that the method should be given.
2949 </p> 2982 </p>
2950 </field> 2983 </field>
2951 <field name="parameters"> 2984 <field name="parameters">
2952 <list><ref>Parameter</ref></list> 2985 <list><ref>RefactoringMethodParameter</ref></list>
2953 <p> 2986 <p>
2954 The parameters that should be defined for the method. 2987 The parameters that should be defined for the method.
2988 <p>
2989 Only trailing parameters may be of POSITIONAL or NAMED kinds.
2990 All the trailing parameters must use the same kind.
Brian Wilkerson 2014/08/14 14:38:08 I think it should be defined to be an error if the
scheglov 2014/08/14 15:54:40 Done.
2991 </p>
2992 <ul>
2993 <li>
2994 To change the order and/or update proposed paramerers, add
2995 parameters with the same identifiers as proposed.
2996 </li>
2997 <li>To add new parameters, omit their identifier.</li>
2998 <li>To remove some parameters, omit them in this list.</li>
2999 </ul>
2955 </p> 3000 </p>
2956 </field> 3001 </field>
2957 <field name="extractAll"> 3002 <field name="extractAll">
2958 <ref>bool</ref> 3003 <ref>bool</ref>
2959 <p> 3004 <p>
2960 True if all occurrences of the expression or statements 3005 True if all occurrences of the expression or statements
2961 should be replaced by an invocation of the method. The 3006 should be replaced by an invocation of the method. The
2962 expression or statements used to initiate the 3007 expression or statements used to initiate the
2963 refactoring will always be replaced. 3008 refactoring will always be replaced.
2964 </p> 3009 </p>
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
3043 <h2>Errors</h2> 3088 <h2>Errors</h2>
3044 <p> 3089 <p>
3045 This section contains a list of all of the errors that are 3090 This section contains a list of all of the errors that are
3046 produced by the server and the data that is returned with each. 3091 produced by the server and the data that is returned with each.
3047 </p> 3092 </p>
3048 <p> 3093 <p>
3049 TBD 3094 TBD
3050 </p> 3095 </p>
3051 </body> 3096 </body>
3052 </html> 3097 </html>
OLDNEW
« no previous file with comments | « pkg/analysis_server/test/integration/protocol_matchers.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698