Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 470713002: Reorder the app order. (Closed)

Created:
6 years, 4 months ago by Jun Mukai
Modified:
6 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Reorder the app order. Loaded app comes first, and then mock icons follow. Otherwise, the loaded calculator app icon won't appear in the new design because the new design has three icons for apps. BUG=None R=oshima@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M athena/content/content_app_model_builder.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jun Mukai
6 years, 4 months ago (2014-08-13 21:26:52 UTC) #1
oshima
lgtm
6 years, 4 months ago (2014-08-14 01:59:55 UTC) #2
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 4 months ago (2014-08-14 16:18:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/470713002/1
6 years, 4 months ago (2014-08-14 16:21:21 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 19:46:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 289677

Powered by Google App Engine
This is Rietveld 408576698