Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1690)

Unified Diff: chrome/browser/extensions/context_menu_matcher.cc

Issue 470693003: Cleanup: Remove more unneeded ifdefs in chrome/browser/extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/context_menu_matcher.h ('k') | chrome/browser/extensions/data_deleter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/context_menu_matcher.cc
diff --git a/chrome/browser/extensions/context_menu_matcher.cc b/chrome/browser/extensions/context_menu_matcher.cc
index 18a0058d5b60204ca6c05a449a9f2b41ac308884..81cb9712a037365e008541abf347eb4338ace606 100644
--- a/chrome/browser/extensions/context_menu_matcher.cc
+++ b/chrome/browser/extensions/context_menu_matcher.cc
@@ -6,30 +6,18 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/app/chrome_command_ids.h"
-#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_util.h"
+#include "chrome/common/extensions/api/context_menus.h"
#include "content/public/browser/browser_context.h"
#include "content/public/common/context_menu_params.h"
-#include "extensions/browser/extension_system.h"
+#include "extensions/browser/extension_registry.h"
#include "ui/gfx/favicon_size.h"
#include "ui/gfx/image/image.h"
-#if defined(ENABLE_EXTENSIONS)
-#include "chrome/common/extensions/api/context_menus.h"
-#endif
-
namespace extensions {
namespace {
-int GetActionMenuTopLevelLimit() {
-#if defined(ENABLE_EXTENSIONS)
- return api::context_menus::ACTION_MENU_TOP_LEVEL_LIMIT;
-#else
- return 0;
-#endif
-}
-
// The range of command IDs reserved for extension's custom menus.
// TODO(oshima): These values will be injected by embedders.
int extensions_context_custom_first = IDC_EXTENSIONS_CONTEXT_CUSTOM_FIRST;
@@ -77,7 +65,7 @@ void ContextMenuMatcher::AppendExtensionItems(
MenuItem::List items;
bool can_cross_incognito;
if (!GetRelevantExtensionTopLevelItems(
- extension_key, &extension, &can_cross_incognito, items))
+ extension_key, &extension, &can_cross_incognito, &items))
return;
if (items.empty())
@@ -151,7 +139,7 @@ base::string16 ContextMenuMatcher::GetTopLevelContextMenuTitle(
MenuItem::List items;
bool can_cross_incognito;
GetRelevantExtensionTopLevelItems(
- extension_key, &extension, &can_cross_incognito, items);
+ extension_key, &extension, &can_cross_incognito, &items);
base::string16 title;
@@ -196,11 +184,10 @@ bool ContextMenuMatcher::GetRelevantExtensionTopLevelItems(
const MenuItem::ExtensionKey& extension_key,
const Extension** extension,
bool* can_cross_incognito,
- MenuItem::List& items) {
- ExtensionService* service =
- extensions::ExtensionSystem::Get(browser_context_)->extension_service();
- *extension = service->GetExtensionById(extension_key.extension_id, false);
-
+ MenuItem::List* items) {
+ *extension = ExtensionRegistry::Get(
+ browser_context_)->enabled_extensions().GetByID(
+ extension_key.extension_id);
if (!*extension)
return false;
@@ -211,8 +198,7 @@ bool ContextMenuMatcher::GetRelevantExtensionTopLevelItems(
return false;
*can_cross_incognito = util::CanCrossIncognito(*extension, browser_context_);
- items = GetRelevantExtensionItems(*all_items,
- *can_cross_incognito);
+ *items = GetRelevantExtensionItems(*all_items, *can_cross_incognito);
return true;
}
@@ -264,8 +250,9 @@ void ContextMenuMatcher::RecursivelyAppendExtensionItems(
// Action context menus have a limit for top level extension items to
// prevent control items from being pushed off the screen, since extension
// items will not be placed in a submenu.
+ const int top_level_limit = api::context_menus::ACTION_MENU_TOP_LEVEL_LIMIT;
if (menu_id >= extensions_context_custom_last ||
- (is_action_menu_top_level && num_items >= GetActionMenuTopLevelLimit()))
+ (is_action_menu_top_level && num_items >= top_level_limit))
return;
extension_item_map_[menu_id] = item->id();
« no previous file with comments | « chrome/browser/extensions/context_menu_matcher.h ('k') | chrome/browser/extensions/data_deleter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698