Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 470663002: ash: Remove a few unused includes. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang, Daniel Erat
CC:
chromium-reviews, sadrul, tdanderson+overview_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

ash: Remove a few unused includes. See https://codereview.chromium.org/467193003/ for how. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289472

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M ash/desktop_background/desktop_background_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/desktop_background/wallpaper_resizer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/keyboard_overlay/keyboard_overlay_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_alignment_menu.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/context_menu.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/audio/tray_audio.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/system/chromeos/network/tray_vpn.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/chromeos/tray_tracing.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/ime/tray_ime.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/status_area_widget_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/user/accounts_detailed_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/user/accounts_detailed_view.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/win/audio/tray_audio_delegate_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/overview/window_selector_window.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/panels/panel_frame_view.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
6 years, 4 months ago (2014-08-13 16:59:35 UTC) #1
Lei Zhang
lgtm, but I think you still need an ash/ OWNER.
6 years, 4 months ago (2014-08-13 17:13:47 UTC) #2
Nico
+derat for ash/OWNERS
6 years, 4 months ago (2014-08-13 17:18:58 UTC) #3
Daniel Erat
lgtm
6 years, 4 months ago (2014-08-13 17:28:20 UTC) #4
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-13 17:28:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/470663002/20001
6 years, 4 months ago (2014-08-13 17:29:48 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-13 23:32:28 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 06:06:24 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 289472

Powered by Google App Engine
This is Rietveld 408576698