Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 470653003: [Sync] Disable unrecoverable error uploading (Closed)

Created:
6 years, 4 months ago by Nicolas Zea
Modified:
6 years, 4 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Sync] Disable unrecoverable error uploading Favicons is known to have issues that trigger errors. Until those are resolved the error uploading should be reduced. Disable for now. BUG=384552 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/sync/glue/chrome_report_unrecoverable_error.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nicolas Zea
PTAL
6 years, 4 months ago (2014-08-13 18:55:32 UTC) #1
rlarocque
On 2014/08/13 18:55:32, Nicolas Zea wrote: > PTAL lgtm
6 years, 4 months ago (2014-08-13 18:58:32 UTC) #2
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 4 months ago (2014-08-13 18:59:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/470653003/1
6 years, 4 months ago (2014-08-13 19:02:24 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 19:17:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 289346

Powered by Google App Engine
This is Rietveld 408576698