Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: chrome/browser/profiles/profile_metrics.cc

Issue 470643002: Add metrics to the new ProfileChooser Tutorials (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename histograms Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_metrics.cc
diff --git a/chrome/browser/profiles/profile_metrics.cc b/chrome/browser/profiles/profile_metrics.cc
index 63c5f19ff3b8aebc4ba6843d9a98fc5f125155f6..f07367afc9d81a3f4692d4f455f37cf7169e99e0 100644
--- a/chrome/browser/profiles/profile_metrics.cc
+++ b/chrome/browser/profiles/profile_metrics.cc
@@ -365,6 +365,26 @@ void ProfileMetrics::LogProfileDelete(bool profile_was_signed_in) {
UMA_HISTOGRAM_BOOLEAN("Profile.Delete", profile_was_signed_in);
}
+void ProfileMetrics::LogProfileDesktopSignin(ProfileDesktopSignin metric) {
+ DCHECK(metric < NUM_PROFILE_DESKTOP_SIGNIN_METRICS);
Alexei Svitkine (slow) 2014/08/14 17:59:46 Nit: Can this be DCHECK_LT? Same below.
Mike Lerman 2014/08/14 18:15:30 Didn't know that was an option. Done, thanks!
+ UMA_HISTOGRAM_ENUMERATION("Profile.NewAvatarMenu.Signin", metric,
+ NUM_PROFILE_DESKTOP_SIGNIN_METRICS);
+}
+
+void ProfileMetrics::LogProfileNewAvatarMenuFRE(
+ ProfileNewAvatarMenuFRE metric) {
+ DCHECK(metric < NUM_PROFILE_AVATAR_MENU_UPGRADE_METRICS);
+ UMA_HISTOGRAM_ENUMERATION("Profile.NewAvatarMenu.FirstRun", metric,
+ NUM_PROFILE_AVATAR_MENU_UPGRADE_METRICS);
+}
+
+void ProfileMetrics::LogProfileNewAvatarMenuNotYou(
+ ProfileNewAvatarMenuNotYou metric) {
+ DCHECK(metric < NUM_PROFILE_AVATAR_MENU_NOT_YOU_METRICS);
+ UMA_HISTOGRAM_ENUMERATION("Profile.NewAvatarMenu.NotYou", metric,
+ NUM_PROFILE_AVATAR_MENU_NOT_YOU_METRICS);
+}
+
#if defined(OS_ANDROID)
void ProfileMetrics::LogProfileAndroidAccountManagementMenu(
ProfileAndroidAccountManagementMenu metric,

Powered by Google App Engine
This is Rietveld 408576698