Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 986592bf8fe2cd1823ec2dff83a7eafa939cf9e4..bdffb71506a11508be6047975e66d70e97250517 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -24668,7 +24668,7 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| -<histogram name="Profile.DesktopMenu" enum="ProfileDesktopMenu"> |
| +<histogram name="Profile.DesktopMenu" enum="ProfileDesktopSignin"> |
| <owner>mlerman@chromium.org</owner> |
| <summary> |
| Track user interactions that can be performed in the user menu and user |
| @@ -24721,6 +24721,22 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Profile.NewAvatarMenuFRE" enum="ProfileNewAvatarMenuFRE"> |
| + <owner>mlerman@chromium.org</owner> |
| + <summary> |
| + Histogram for tracking user interactions with the bubble that appears for |
|
Alexei Svitkine (slow)
2014/08/14 15:53:39
Nit: "Histogram for" is redundant. Just "Tracks us
Mike Lerman
2014/08/14 17:54:55
Done.
|
| + signed in users in the new avatar menu on the first run. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Profile.NewAvatarMenuNotYou" enum="ProfileNewAvatarMenuNotYou"> |
|
Alexei Svitkine (slow)
2014/08/14 15:53:39
I suggest using two levels of dotted prefixes, so
Mike Lerman
2014/08/14 17:54:55
Done.
|
| + <owner>mlerman@chromium.org</owner> |
| + <summary> |
| + Histogram for tracking user interactions with the Not You? bubble that users |
| + can navigate to from the Upgrade bubble during the first run. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Profile.NumberOfAccountsPerProfile"> |
| <owner>mlerman@chromium.org</owner> |
| <summary> |
| @@ -24829,6 +24845,15 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Profile.ProfileDesktopSignin" enum="ProfileDesktopSignin"> |
| + <owner>mlerman@chromium.org</owner> |
| + <summary> |
| + Histogram for tracking user interactions with the signin bubble that appears |
| + in the New Avatar Menu upon signin. This bubble appears after the user signs |
| + in using the Inline Signin flow. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Profile.ProfileError" enum="ProfileErrorType"> |
| <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| <summary> |
| @@ -46971,6 +46996,18 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </int> |
| </enum> |
| +<enum name="ProfileDesktopSignin" type="int"> |
| + <int value="0" label="View Signin Bubble"> |
| + User viewed the signin bubble after successfully using the inline signin. |
| + </int> |
| + <int value="1" label="Dismiss"> |
| + User selected ok to dismiss the signin bubble. |
| + </int> |
| + <int value="2" label="Settings"> |
| + User opened the settings from the signin bubble. |
| + </int> |
| +</enum> |
| + |
| <enum name="ProfileErrorType" type="int"> |
| <int value="0" label="History error"/> |
| <int value="1" label="Preferences error"/> |
| @@ -47010,6 +47047,34 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| <int value="1" label="Deleted a profile"/> |
| </enum> |
| +<enum name="ProfileNewAvatarMenuFRE" type="int"> |
| + <int value="0" label="View Upgrade Bubble"> |
| + User views the upgrade bubble. |
| + </int> |
| + <int value="1" label="Dismiss">User dismissed the upgrade bubble.</int> |
| + <int value="2" label="What's New"> |
| + User selects 'What's New' in the upgrade bubble. |
| + </int> |
| + <int value="3" label="Not You?"> |
| + User selects 'Not You?' in the upgrade bubble. |
| + </int> |
| +</enum> |
| + |
| +<enum name="ProfileNewAvatarMenuNotYou" type="int"> |
| + <int value="0" label="View Not You? Bubble"> |
| + User views the Not You? bubble. |
| + </int> |
| + <int value="1" label="Back"> |
| + User selects back from within the Not You? bubble. |
| + </int> |
| + <int value="2" label="Add Person"> |
| + User adds a person from within the Not You? bubble. |
| + </int> |
| + <int value="3" label="Disconnect"> |
| + User chooses to disconnect (sign out) from within the Not You? bubble. |
| + </int> |
| +</enum> |
| + |
| <enum name="ProfileOpen" type="int"> |
| <int value="0" label="Add new user"/> |
| <int value="1" label="Add new user from icon menu"/> |