Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

Issue 470643002: Add metrics to the new ProfileChooser Tutorials (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc b/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
index ce4fec8e371513f86397654fc82ff472a3020eed..64d57e23f4fe3c54b64990596d2043ad77e38a1e 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
@@ -83,9 +83,8 @@ void ProfileChooserViewBrowserTest::OpenProfileChooserView() {
#define MAYBE_ViewProfileUMA ViewProfileUMA
#endif
-// TODO(mlerman): Re-enable the test to MAYBE_ViewProfileUMA once there is a
-// launch plan for EnableAccountConsistency.
-IN_PROC_BROWSER_TEST_F(ProfileChooserViewBrowserTest, DISABLED_ViewProfileUMA) {
+IN_PROC_BROWSER_TEST_F(ProfileChooserViewBrowserTest, MAYBE_ViewProfileUMA) {
+ UMAHistogramHelper histograms;
// If multiprofile mode is not enabled, you can't switch between profiles.
if (!profiles::IsMultipleProfilesEnabled())
return;
@@ -94,4 +93,8 @@ IN_PROC_BROWSER_TEST_F(ProfileChooserViewBrowserTest, DISABLED_ViewProfileUMA) {
profile->GetPrefs()->SetInteger(prefs::kProfileAvatarTutorialShown, 0);
ASSERT_NO_FATAL_FAILURE(OpenProfileChooserView());
+
+ histograms.Fetch();
+ histograms.ExpectUniqueSample("Profile.NewAvatarMenu.Upgrade",
+ ProfileMetrics::PROFILE_AVATAR_MENU_UPGRADE_VIEW, 1);
}

Powered by Google App Engine
This is Rietveld 408576698