Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: Source/core/rendering/style/SVGRenderStyle.cpp

Issue 470633002: Rename repaint to paintInvalidation in rendering/style. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/style/SVGRenderStyle.h ('k') | Source/core/rendering/style/StyleDifference.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/style/SVGRenderStyle.cpp
diff --git a/Source/core/rendering/style/SVGRenderStyle.cpp b/Source/core/rendering/style/SVGRenderStyle.cpp
index 76654dfc7b2beacb0c0f13ee515aac4b56d737c9..d5b92d9078d9fdd0b073780505c17c20af3bee5c 100644
--- a/Source/core/rendering/style/SVGRenderStyle.cpp
+++ b/Source/core/rendering/style/SVGRenderStyle.cpp
@@ -119,19 +119,19 @@ StyleDifference SVGRenderStyle::diff(const SVGRenderStyle* other) const
{
StyleDifference styleDifference;
- if (diffNeedsLayoutAndRepaint(other)) {
+ if (diffNeedsLayoutAndPaintInvalidation(other)) {
styleDifference.setNeedsFullLayout();
- styleDifference.setNeedsRepaintObject();
- } else if (diffNeedsRepaint(other)) {
- styleDifference.setNeedsRepaintObject();
+ styleDifference.setNeedsPaintInvalidationObject();
+ } else if (diffNeedsPaintInvalidation(other)) {
+ styleDifference.setNeedsPaintInvalidationObject();
}
return styleDifference;
}
-bool SVGRenderStyle::diffNeedsLayoutAndRepaint(const SVGRenderStyle* other) const
+bool SVGRenderStyle::diffNeedsLayoutAndPaintInvalidation(const SVGRenderStyle* other) const
{
- // If resources change, we need a relayout, as the presence of resources influences the repaint rect.
+ // If resources change, we need a relayout, as the presence of resources influences the paint invalidation rect.
if (resources != other->resources)
return true;
@@ -180,12 +180,12 @@ bool SVGRenderStyle::diffNeedsLayoutAndRepaint(const SVGRenderStyle* other) cons
return false;
}
-bool SVGRenderStyle::diffNeedsRepaint(const SVGRenderStyle* other) const
+bool SVGRenderStyle::diffNeedsPaintInvalidation(const SVGRenderStyle* other) const
{
if (stroke->opacity != other->stroke->opacity)
return true;
- // Painting related properties only need repaints.
+ // Painting related properties only need paint invalidation.
if (misc.get() != other->misc.get()) {
if (misc->floodColor != other->misc->floodColor
|| misc->floodOpacity != other->misc->floodOpacity
@@ -193,7 +193,7 @@ bool SVGRenderStyle::diffNeedsRepaint(const SVGRenderStyle* other) const
return true;
}
- // If fill changes, we just need to repaint. Fill boundaries are not influenced by this, only by the Path, that RenderSVGPath contains.
+ // If fill changes, we just need to issue paint invalidations. Fill boundaries are not influenced by this, only by the Path, that RenderSVGPath contains.
if (fill.get() != other->fill.get()) {
if (fill->paintType != other->fill->paintType
|| fill->paintColor != other->fill->paintColor
@@ -202,11 +202,11 @@ bool SVGRenderStyle::diffNeedsRepaint(const SVGRenderStyle* other) const
return true;
}
- // If gradient stops change, we just need to repaint. Style updates are already handled through RenderSVGGradientSTop.
+ // If gradient stops change, we just need to issue paint invalidations. Style updates are already handled through RenderSVGGradientSTop.
if (stops != other->stops)
return true;
- // Changes of these flags only cause repaints.
+ // Changes of these flags only cause paint invalidations.
if (svg_inherited_flags._colorRendering != other->svg_inherited_flags._colorRendering
|| svg_inherited_flags._shapeRendering != other->svg_inherited_flags._shapeRendering
|| svg_inherited_flags._clipRule != other->svg_inherited_flags._clipRule
« no previous file with comments | « Source/core/rendering/style/SVGRenderStyle.h ('k') | Source/core/rendering/style/StyleDifference.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698