Unify MachineType and RepType.

test/cctest/compiler/test-representation-change.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits>
 
 #include "src/v8.h"
 #include "test/cctest/cctest.h"
 #include "test/cctest/compiler/graph-builder-tester.h"
 
@@ skipping 47 matching lines @@
     ValueMatcher<double> m(n);
     CHECK_EQ(IrOpcode::kNumberConstant, n->opcode());
     CHECK(m.HasValue());
     CHECK_EQ(expected, m.Value());
   }
 
   Node* Parameter(int index = 0) {
     return graph()->NewNode(common()->Parameter(index), graph()->start());
   }
 
-  void CheckTypeError(RepTypeUnion from, RepTypeUnion to) {
+  void CheckTypeError(MachineTypeUnion from, MachineTypeUnion to) {
     changer()->testing_type_errors_ = true;
     changer()->type_error_ = false;
     Node* n = Parameter(0);
     Node* c = changer()->GetRepresentationFor(n, from, to);
+    CHECK(changer()->type_error_);
     CHECK_EQ(n, c);
-    CHECK(changer()->type_error_);
   }
 
-  void CheckNop(RepTypeUnion from, RepTypeUnion to) {
+  void CheckNop(MachineTypeUnion from, MachineTypeUnion to) {
     Node* n = Parameter(0);
     Node* c = changer()->GetRepresentationFor(n, from, to);
     CHECK_EQ(n, c);
   }
 };
 }
 }
 }  // namespace v8::internal::compiler
 
 
-static const RepType all_reps[] = {rBit, rWord32, rWord64, rFloat64, rTagged};
+static const MachineType all_reps[] = {rBit, rWord32, rWord64, rFloat64,
+                                       rTagged};
 
 
 // TODO(titzer): lift this to ValueHelper
 static const double double_inputs[] = {
     0.0,   -0.0,    1.0,    -1.0,        0.1,         1.4,    -1.7,
     2,     5,       6,      982983,      888,         -999.8, 3.1e7,
     -2e66, 2.3e124, -12e73, V8_INFINITY, -V8_INFINITY};
 
 
 static const int32_t int32_inputs[] = {
@@ skipping 50 matching lines @@
   }
 
   for (size_t i = 0; i < ARRAY_SIZE(uint32_inputs); i++) {
     Node* n = r.jsgraph()->Int32Constant(uint32_inputs[i]);
     Node* c = r.changer()->GetRepresentationFor(n, rWord32 | tUint32, rTagged);
     r.CheckNumberConstant(c, static_cast<double>(uint32_inputs[i]));
   }
 }
 
 
-static void CheckChange(IrOpcode::Value expected, RepTypeUnion from,
-                        RepTypeUnion to) {
+static void CheckChange(IrOpcode::Value expected, MachineTypeUnion from,
+                        MachineTypeUnion to) {
   RepresentationChangerTester r;
 
   Node* n = r.Parameter();
   Node* c = r.changer()->GetRepresentationFor(n, from, to);
 
   CHECK_NE(c, n);
   CHECK_EQ(expected, c->opcode());
   CHECK_EQ(n, c->InputAt(0));
 }
 
@@ skipping 36 matching lines @@
   for (size_t i = 0; i < ARRAY_SIZE(all_reps); i++) {
     r.CheckNop(all_reps[i], all_reps[i]);
   }
 
   // 32-bit or 64-bit words can be used as branch conditions (rBit).
   r.CheckNop(rWord32, rBit);
   r.CheckNop(rWord32, rBit | tBool);
   r.CheckNop(rWord64, rBit);
   r.CheckNop(rWord64, rBit | tBool);
 
+  // 32-bit words can be used as smaller word sizes and vice versa, because
+  // loads from memory implicitly sign or zero extend the value to the
+  // full machine word size, and stores implicitly truncate.
+  r.CheckNop(rWord32, rWord8);
+  r.CheckNop(rWord32, rWord16);
+  r.CheckNop(rWord32, rWord32);
+  r.CheckNop(rWord8, rWord32);
+  r.CheckNop(rWord16, rWord32);
+
   // rBit (result of comparison) is implicitly a wordish thing.
+  r.CheckNop(rBit, rWord8);
+  r.CheckNop(rBit | tBool, rWord8);
+  r.CheckNop(rBit, rWord16);
+  r.CheckNop(rBit | tBool, rWord16);
   r.CheckNop(rBit, rWord32);
   r.CheckNop(rBit | tBool, rWord32);
   r.CheckNop(rBit, rWord64);
   r.CheckNop(rBit | tBool, rWord64);
 }
 
 
 TEST(TypeErrors) {
   RepresentationChangerTester r;
 
@@ skipping 39 matching lines @@
   // rW64
   // tIrW64
   // tUrW64
   // rF64
   // tIrF64
   // tUrF64
   // tArF64
   // rT
   // tArT
 }