SkPatchGrid bench

Added bench for grid of patches.

It is on top of my previous cl to fix the mem leaks of the regular patch bench. 

NOTREECHECKS=true
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/7e5598a004d0aceb630707053566bee523feea66

[dandov, 2014-08-14 19:19:49]

Just added a bench for SKPatchGrid that has 3 different sizes  and combinations
of the optional parameters of drawPatch

[dandov, 2014-08-14 20:44:07]

Set up things inside onPreDraw.

Looking at how SkPaint::setShader works I think I can unref in onPreDraw and the
only object that will hold a reference to the shader will be fPaint which does
the final unref in its destructor. I also ran it through valgrind and it didn't
show memory problems.

[egdaniel, 2014-08-14 21:08:45]

https://codereview.chromium.org/470543004/diff/20001/bench/PatchGridBench.cpp
File bench/PatchGridBench.cpp (right):

https://codereview.chromium.org/470543004/diff/20001/bench/PatchGridBench.cpp...
bench/PatchGridBench.cpp:15: #include "SkRandom.h"
Is this needed?

https://codereview.chromium.org/470543004/diff/20001/bench/PatchGridBench.cpp...
bench/PatchGridBench.cpp:16: #include "SkShader.h"
needed?

https://codereview.chromium.org/470543004/diff/20001/bench/PatchGridBench.cpp...
bench/PatchGridBench.cpp:18: #include "SkTArray.h"
needed?

https://codereview.chromium.org/470543004/diff/20001/bench/PatchGridBench.cpp...
bench/PatchGridBench.cpp:55: virtual void setGrid() {
is virtual needed here?

https://codereview.chromium.org/470543004/diff/20001/bench/PatchGridBench.cpp...
bench/PatchGridBench.cpp:176: vertexMode.set("colors&texs");
lets not use an & in the name. can probably just use another _

[dandov, 2014-08-14 21:20:39]

https://codereview.chromium.org/470543004/diff/20001/bench/PatchGridBench.cpp
File bench/PatchGridBench.cpp (right):

https://codereview.chromium.org/470543004/diff/20001/bench/PatchGridBench.cpp...
bench/PatchGridBench.cpp:15: #include "SkRandom.h"
On 2014/08/14 21:08:45, egdaniel wrote:
> Is this needed?

Done.

https://codereview.chromium.org/470543004/diff/20001/bench/PatchGridBench.cpp...
bench/PatchGridBench.cpp:16: #include "SkShader.h"
On 2014/08/14 21:08:45, egdaniel wrote:
> needed?

Done.

https://codereview.chromium.org/470543004/diff/20001/bench/PatchGridBench.cpp...
bench/PatchGridBench.cpp:18: #include "SkTArray.h"
On 2014/08/14 21:08:44, egdaniel wrote:
> needed?

Done.

https://codereview.chromium.org/470543004/diff/20001/bench/PatchGridBench.cpp...
bench/PatchGridBench.cpp:55: virtual void setGrid() {
On 2014/08/14 21:08:44, egdaniel wrote:
> is virtual needed here?

Removed virtual.

https://codereview.chromium.org/470543004/diff/20001/bench/PatchGridBench.cpp...
bench/PatchGridBench.cpp:150: virtual SkShader* createShader() {
Also removed virtual from this.

https://codereview.chromium.org/470543004/diff/20001/bench/PatchGridBench.cpp...
bench/PatchGridBench.cpp:176: vertexMode.set("colors&texs");
On 2014/08/14 21:08:44, egdaniel wrote:
> lets not use an & in the name. can probably just use another _

Done.

[egdaniel, 2014-08-15 03:46:27]

lgtm with comment nit

https://codereview.chromium.org/470543004/diff/40001/bench/PatchGridBench.cpp
File bench/PatchGridBench.cpp (right):

https://codereview.chromium.org/470543004/diff/40001/bench/PatchGridBench.cpp...
bench/PatchGridBench.cpp:14: 
Add very brief comment on what this bench is testing and the various options you
are trying to exercise here

[dandov, 2014-08-15 13:56:15]

On 2014/08/15 03:46:27, egdaniel wrote:
> lgtm with comment nit
> 
> https://codereview.chromium.org/470543004/diff/40001/bench/PatchGridBench.cpp
> File bench/PatchGridBench.cpp (right):
> 
>
https://codereview.chromium.org/470543004/diff/40001/bench/PatchGridBench.cpp...
> bench/PatchGridBench.cpp:14: 
> Add very brief comment on what this bench is testing and the various options
you
> are trying to exercise here

Added comments for PatchBench and PatchGridBench.

[dandov, 2014-08-15 13:56:30]

The CQ bit was checked by dandov@google.com

[commit-bot: I haz the power, 2014-08-15 13:57:12]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/dandov@google.com/470543004/60001

[commit-bot: I haz the power, 2014-08-15 13:57:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-15 13:57:17]

Failed to apply patch for src/core/SkDevice.cpp:
While running git apply --index -p1;
  <stdin>:14: trailing whitespace.
      // If it fails to generate the vertices, then we do not draw. 
  error: patch failed: src/core/SkDevice.cpp:86
  error: src/core/SkDevice.cpp: patch does not apply

Patch:       src/core/SkDevice.cpp
Index: src/core/SkDevice.cpp
diff --git a/src/core/SkDevice.cpp b/src/core/SkDevice.cpp
index
50755c94ed5e65999574ec120ff3af5610344960..f4ae7b138173cf7132b67bda531ffc022ac83d61
100644
--- a/src/core/SkDevice.cpp
+++ b/src/core/SkDevice.cpp
@@ -86,10 +86,12 @@ void SkBaseDevice::drawPatch(const SkDraw& draw, const
SkPoint cubics[12], const
     SkISize lod = SkPatchUtils::GetLevelOfDetail(cubics, draw.fMatrix);
 
     // It automatically adjusts lodX and lodY in case it exceeds the number of
indices.
-    SkPatchUtils::getVertexData(&data, cubics, colors, texCoords, lod.width(),
lod.height());
-    this->drawVertices(draw, SkCanvas::kTriangles_VertexMode,
data.fVertexCount, data.fPoints,
-                       data.fTexCoords, data.fColors, xmode, data.fIndices,
data.fIndexCount,
-                       paint);
+    // If it fails to generate the vertices, then we do not draw. 
+    if (SkPatchUtils::getVertexData(&data, cubics, colors, texCoords,
lod.width(), lod.height())) {
+        this->drawVertices(draw, SkCanvas::kTriangles_VertexMode,
data.fVertexCount, data.fPoints,
+                           data.fTexCoords, data.fColors, xmode, data.fIndices,
data.fIndexCount,
+                           paint);
+    }
 }
 
 bool SkBaseDevice::readPixels(const SkImageInfo& info, void* dstP, size_t
rowBytes, int x, int y) {

[dandov, 2014-08-15 14:14:23]

The CQ bit was checked by dandov@google.com

[commit-bot: I haz the power, 2014-08-15 14:15:12]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/dandov@google.com/470543004/80001

[bsalomon, 2014-08-15 17:38:03]

Can you put SK_OVERRIDE on all the virtual overrides? Also, OK to
NOTREECHECKS=true this one.

[dandov, 2014-08-15 20:16:18]

The CQ bit was unchecked by dandov@google.com

[dandov, 2014-08-15 20:22:09]

The CQ bit was checked by dandov@google.com

[commit-bot: I haz the power, 2014-08-15 20:22:53]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/dandov@google.com/470543004/100001

[commit-bot: I haz the power, 2014-08-15 20:31:00]

Committed patchset #6 (100001) as 7e5598a004d0aceb630707053566bee523feea66