Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 470543002: DevTools: Don't allow native global functions in injected script. (Closed)

Created:
6 years, 4 months ago by aandrey
Modified:
6 years, 4 months ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Don't allow native global functions in injected script. R=yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180420

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -9 lines) Patch
M LayoutTests/inspector/console/console-format-collections.html View 1 2 chunks +17 lines, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-format-collections-expected.txt View 1 4 chunks +32 lines, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-tainted-globals.html View 1 chunk +27 lines, -4 lines 0 comments Download
M LayoutTests/inspector/console/console-tainted-globals-expected.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 1 2 2 chunks +11 lines, -2 lines 0 comments Download
M Source/devtools/scripts/check_injected_script_source.py View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
aandrey
6 years, 4 months ago (2014-08-13 09:54:52 UTC) #1
pfeldman
lgtm
6 years, 4 months ago (2014-08-13 14:48:27 UTC) #2
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-08-13 15:18:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/470543002/60001
6 years, 4 months ago (2014-08-13 15:19:53 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 16:34:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 16:50:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19683)
6 years, 4 months ago (2014-08-13 16:50:57 UTC) #7
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-08-13 17:03:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/470543002/60001
6 years, 4 months ago (2014-08-13 17:04:15 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 17:16:57 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 17:18:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19691)
6 years, 4 months ago (2014-08-13 17:18:40 UTC) #12
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 4 months ago (2014-08-17 17:56:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/470543002/60001
6 years, 4 months ago (2014-08-17 17:57:12 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-17 18:27:06 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (60001) as 180420

Powered by Google App Engine
This is Rietveld 408576698