Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 470533002: Add FOR_INT32_SHIFTS to value-helper.h (Closed)

Created:
6 years, 4 months ago by titzer
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add FOR_INT32_SHIFTS to value-helper.h R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23100

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -62 lines) Patch
M test/cctest/compiler/test-run-machops.cc View 31 chunks +31 lines, -62 lines 0 comments Download
M test/cctest/compiler/value-helper.h View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
titzer
6 years, 4 months ago (2014-08-13 09:43:00 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/470533002/diff/1/test/cctest/compiler/value-helper.h File test/cctest/compiler/value-helper.h (right): https://codereview.chromium.org/470533002/diff/1/test/cctest/compiler/value-helper.h#newcode127 test/cctest/compiler/value-helper.h:127: #define FOR_INT32_SHIFTS(var) for (int32_t var = 0; var < ...
6 years, 4 months ago (2014-08-13 09:45:02 UTC) #2
titzer
On 2014/08/13 09:45:02, Benedikt Meurer wrote: > https://codereview.chromium.org/470533002/diff/1/test/cctest/compiler/value-helper.h > File test/cctest/compiler/value-helper.h (right): > > https://codereview.chromium.org/470533002/diff/1/test/cctest/compiler/value-helper.h#newcode127 ...
6 years, 4 months ago (2014-08-13 09:57:20 UTC) #3
Benedikt Meurer
lgtm
6 years, 4 months ago (2014-08-13 09:58:40 UTC) #4
titzer
6 years, 4 months ago (2014-08-13 10:30:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 23100 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698