|
|
Created:
6 years, 4 months ago by hush (inactive) Modified:
4 years, 5 months ago CC:
chromium-reviews, android-webview-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionAdd an "isInsideVSync" check.
Prevent calling postInvalidateOnAnimate inside VSync handler, because
this will cause the invalidation to be one frame delayed.
BUG=394604
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291525
Patch Set 1 #
Messages
Total messages: 28 (0 generated)
Yaron, can you look at ui/android? This is a part of the CL from https://codereview.chromium.org/457913002
by the way, Bo and I were wondering why VSyncMonitor is not a singleton while it wraps the Android system's singleton Choreorgrapher
This seems like sievers territory. If he's happy, I can RS
On 2014/08/22 01:15:22, Yaron wrote: > This seems like sievers territory. If he's happy, I can RS Daniel lgtm'ed the ui/ part in https://codereview.chromium.org/457913002
lgtm
aw lgtm
The CQ bit was checked by hush@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/470523006/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2014/08/22 02:31:11, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium.linux > (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Yaron's email is misspelled in ui/android/OWNERS... Maybe you can correct that in this CL too :p
On 2014/08/22 02:39:45, boliu wrote: > On 2014/08/22 02:31:11, I haz the power (commit-bot) wrote: > > Try jobs failed on following builders: > > chromium_presubmit on tryserver.chromium.linux > > > (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) > > Yaron's email is misspelled in ui/android/OWNERS... > > Maybe you can correct that in this CL too :p Ehh, I misread. Not sure why presubmit is not happy
The CQ bit was checked by hush@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/470523006/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Hi Jared! Can you take a look at ui/ part? Thanks!
On 2014/08/22 03:32:01, hush wrote: > Hi Jared! > Can you take a look at ui/ part? Thanks! Rubberstamp lgtm.
The CQ bit was checked by hush@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/470523006/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
The CQ bit was checked by hush@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/470523006/1
Message was sent while issue was closed.
Committed patchset #1 (1) as 291525 |