Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 470523006: Add an "isInsideVSync" check. (Closed)

Created:
6 years, 4 months ago by hush (inactive)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add an "isInsideVSync" check. Prevent calling postInvalidateOnAnimate inside VSync handler, because this will cause the invalidation to be one frame delayed. BUG=394604 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -9 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 4 chunks +11 lines, -7 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/VSyncMonitor.java View 2 chunks +20 lines, -2 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/WindowAndroid.java View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
hush (inactive)
Yaron, can you look at ui/android? This is a part of the CL from https://codereview.chromium.org/457913002
6 years, 4 months ago (2014-08-21 21:57:36 UTC) #1
hush (inactive)
by the way, Bo and I were wondering why VSyncMonitor is not a singleton while ...
6 years, 4 months ago (2014-08-21 21:59:17 UTC) #2
Yaron
This seems like sievers territory. If he's happy, I can RS
6 years, 4 months ago (2014-08-22 01:15:22 UTC) #3
hush (inactive)
On 2014/08/22 01:15:22, Yaron wrote: > This seems like sievers territory. If he's happy, I ...
6 years, 4 months ago (2014-08-22 01:26:06 UTC) #4
Yaron
lgtm
6 years, 4 months ago (2014-08-22 01:28:45 UTC) #5
boliu
aw lgtm
6 years, 4 months ago (2014-08-22 01:29:17 UTC) #6
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 4 months ago (2014-08-22 01:31:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/470523006/1
6 years, 4 months ago (2014-08-22 01:32:21 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 02:28:58 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 02:31:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/5968)
6 years, 4 months ago (2014-08-22 02:31:11 UTC) #11
boliu
On 2014/08/22 02:31:11, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 4 months ago (2014-08-22 02:39:45 UTC) #12
boliu
On 2014/08/22 02:39:45, boliu wrote: > On 2014/08/22 02:31:11, I haz the power (commit-bot) wrote: ...
6 years, 4 months ago (2014-08-22 03:03:53 UTC) #13
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 4 months ago (2014-08-22 03:13:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/470523006/1
6 years, 4 months ago (2014-08-22 03:13:59 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 03:25:01 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 03:28:09 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/5981)
6 years, 4 months ago (2014-08-22 03:28:09 UTC) #18
hush (inactive)
Hi Jared! Can you take a look at ui/ part? Thanks!
6 years, 4 months ago (2014-08-22 03:32:01 UTC) #19
jdduke (slow)
On 2014/08/22 03:32:01, hush wrote: > Hi Jared! > Can you take a look at ...
6 years, 4 months ago (2014-08-22 03:35:01 UTC) #20
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 4 months ago (2014-08-22 04:10:32 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/470523006/1
6 years, 4 months ago (2014-08-22 04:11:40 UTC) #22
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 04:19:08 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 05:12:48 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1268)
6 years, 4 months ago (2014-08-22 05:12:49 UTC) #25
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 4 months ago (2014-08-22 21:05:46 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/470523006/1
6 years, 4 months ago (2014-08-22 21:06:49 UTC) #27
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 22:12:18 UTC) #28
Message was sent while issue was closed.
Committed patchset #1 (1) as 291525

Powered by Google App Engine
This is Rietveld 408576698