Issue 470523002: Componentize AutocompleteResult

Issue 470523002: Componentize AutocompleteResult (Closed)

Created:
6 years, 4 months ago by hashimoto

Modified:
6 years, 4 months ago

Reviewers:
Mark P, sky

CC:
chromium-reviews, skanuj+watch_chromium.org, shishir+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, Ilya Sherman, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, jam, dominich, tburkard+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-options_chromium.org, gavinp+prer_chromium.org, jfweitz+watch_chromium.org, asvitkine+watch_chromium.org, Jered, davidben+watch_chromium.org, donnd+watch_chromium.org, dominich+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, James Su, Jun Mukai, Peter Kasting

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Componentize AutocompleteResult BUG=388504 TEST=build TBR=sky@chromium.org for include fix under chrome/browser Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289619

Patch Set 1 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -1544 lines)			Patch
M	chrome/browser/android/omnibox/omnibox_prerender.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/autocomplete/autocomplete_result.h	View	1 chunk	+0 lines, -205 lines	0 comments	Download
D	chrome/browser/autocomplete/autocomplete_result.cc	View	1 chunk	+0 lines, -466 lines	0 comments	Download
D	chrome/browser/autocomplete/autocomplete_result_unittest.cc	View	1 chunk	+0 lines, -843 lines	0 comments	Download
M	chrome/browser/autocomplete/bookmark_provider.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_quick_provider.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_quick_provider_unittest.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider_unittest.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/search_provider.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/shortcuts_backend.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/shortcuts_provider.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/shortcuts_provider_unittest.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/omnibox/omnibox_api_testbase.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/DEPS	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/metrics/omnibox_metrics_provider.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/predictors/autocomplete_action_predictor.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_popup_model.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/search/instant_extended_interactive_uitest.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/home_page_overlay_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/options_ui.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/startup_pages_handler.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/components_tests.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/omnibox.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	components/omnibox/BUILD.gn	View	2 chunks	+3 lines, -0 lines	0 comments	Download
A +	components/omnibox/autocomplete_result.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	components/omnibox/autocomplete_result.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	components/omnibox/autocomplete_result_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download