Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: pdfium.gyp

Issue 470503004: Disable exceptions for the pdfium targets, now that pdfium:29 is done. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdfium.gyp
diff --git a/pdfium.gyp b/pdfium.gyp
index 277c1c74a080523330ced15628c5e5f7074d66cd..5c5b9ca0b0b0c7a64faf7d42b5c50b0c65e34fe7 100644
--- a/pdfium.gyp
+++ b/pdfium.gyp
@@ -13,18 +13,7 @@
['pdf_use_skia==1', {
'defines': ['_SKIA_SUPPORT_'],
}],
- # pdfium uses exceptions. Override the default exceptions-off setting
- # from chromium.
- # TODO: Instead, change pdfium to not use exceptions, and remove this.
- ['OS=="mac"', {
- 'xcode_settings': { 'GCC_ENABLE_CPP_EXCEPTIONS': 'YES', },
- }],
- ['OS=="win"', {
- 'msvs_settings': { 'VCCLCompilerTool': { 'ExceptionHandling': '1', }, },
- 'defines!': [ '_HAS_EXCEPTIONS=0', ],
- }],
['OS=="linux"', {
- 'cflags!': [ '-fno-exceptions', ],
'conditions': [
['target_arch=="x64"', {
'defines' : [ '_FX_CPU_=_FX_X64_', ],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698