Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 470503002: Fix closing the Alert overlay (Closed)

Created:
6 years, 4 months ago by michaelpg
Modified:
6 years, 4 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M chrome/browser/ui/webui/options/certificate_manager_browsertest.js View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/webui/resources/js/cr/ui/page_manager/page_manager.js View 1 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
michaelpg
6 years, 4 months ago (2014-08-13 07:10:39 UTC) #1
Evan Stade
lgtm https://codereview.chromium.org/470503002/diff/1/ui/webui/resources/js/cr/ui/page_manager/page_manager.js File ui/webui/resources/js/cr/ui/page_manager/page_manager.js (right): https://codereview.chromium.org/470503002/diff/1/ui/webui/resources/js/cr/ui/page_manager/page_manager.js#newcode540 ui/webui/resources/js/cr/ui/page_manager/page_manager.js:540: continue; nit: \n https://codereview.chromium.org/470503002/diff/1/ui/webui/resources/js/cr/ui/page_manager/page_manager.js#newcode542 ui/webui/resources/js/cr/ui/page_manager/page_manager.js:542: return page; nit: ...
6 years, 4 months ago (2014-08-13 20:46:36 UTC) #2
michaelpg
Thanks. https://codereview.chromium.org/470503002/diff/1/ui/webui/resources/js/cr/ui/page_manager/page_manager.js File ui/webui/resources/js/cr/ui/page_manager/page_manager.js (right): https://codereview.chromium.org/470503002/diff/1/ui/webui/resources/js/cr/ui/page_manager/page_manager.js#newcode540 ui/webui/resources/js/cr/ui/page_manager/page_manager.js:540: continue; On 2014/08/13 20:46:36, Evan Stade wrote: > ...
6 years, 4 months ago (2014-08-13 21:11:31 UTC) #3
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 4 months ago (2014-08-13 21:11:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/470503002/20001
6 years, 4 months ago (2014-08-13 21:13:48 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-14 03:21:11 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 06:13:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/5837)
6 years, 4 months ago (2014-08-14 06:13:44 UTC) #8
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 4 months ago (2014-08-14 06:41:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/470503002/20001
6 years, 4 months ago (2014-08-14 06:46:20 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 07:10:06 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 289478

Powered by Google App Engine
This is Rietveld 408576698