Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 470493003: Fix font instantiation assertion failure on session restore (Closed)

Created:
6 years, 4 months ago by Dominik Röttsches
Modified:
6 years, 4 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix font instantiation assertion failure on session restore It seems in certain cases font fallback returns a fontconfig interface id which can then later not be reused by Skia. This patch fixes an incorrect fallback to using the family in that case and returns a nullptr instead, which fixes the assertion failure. However, we need to investigate why the Skia typeface creation with the returned fciId is unsuccessful, filed crbug.com/403348 for this remaining question. BUG=273261 R=eae,eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/platform/fonts/skia/FontCacheSkia.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Dominik Röttsches
6 years, 4 months ago (2014-08-13 15:59:37 UTC) #1
eae
LGTM
6 years, 4 months ago (2014-08-13 16:05:26 UTC) #2
Dominik Röttsches
On 2014/08/13 16:05:26, eae wrote: > LGTM Thanks - I think this should eventually land, ...
6 years, 4 months ago (2014-08-13 16:54:26 UTC) #3
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 4 months ago (2014-08-13 18:06:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/470493003/1
6 years, 4 months ago (2014-08-13 18:07:25 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 19:44:43 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 20:54:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22619)
6 years, 4 months ago (2014-08-13 20:54:05 UTC) #8
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 4 months ago (2014-08-13 21:53:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/470493003/1
6 years, 4 months ago (2014-08-13 21:54:15 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 23:10:37 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 00:03:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (1) as 180214

Powered by Google App Engine
This is Rietveld 408576698