Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 470443004: Implement support for numeric font-weights on Windows (Closed)

Created:
6 years, 4 months ago by eae
Modified:
6 years, 4 months ago
Reviewers:
dglazkov
CC:
blink-reviews, Rik, danakj, krit, jamesr, jbroman, pdr., rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Implement support for numeric font-weights on Windows Implement support for numeric font-weights (i.e. 100..900) on platforms using SkFontMgr by switching to the new matchFamilyStyle API instead of the old legacyCreateTypeface one. Currently SkFontMgr is only used on Windows. R=dglazkov@chromium.org BUG=394692 TEST=fast/text/font-weight.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180279

Patch Set 1 #

Patch Set 2 : Limit to DW #

Patch Set 3 : w/expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -6 lines) Patch
M LayoutTests/TestExpectations View 1 2 2 chunks +31 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/font-weight.html View 1 chunk +43 lines, -0 lines 0 comments Download
M Source/platform/fonts/skia/FontCacheSkia.cpp View 1 2 2 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eae
6 years, 4 months ago (2014-08-13 22:23:10 UTC) #1
dglazkov
lgtm
6 years, 4 months ago (2014-08-13 22:32:42 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 4 months ago (2014-08-13 22:55:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/470443004/1
6 years, 4 months ago (2014-08-13 22:56:09 UTC) #4
eae
The CQ bit was unchecked by eae@chromium.org
6 years, 4 months ago (2014-08-13 23:11:27 UTC) #5
eae
The CQ bit was checked by eae@chromium.org
6 years, 4 months ago (2014-08-14 15:17:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/470443004/60001
6 years, 4 months ago (2014-08-14 15:18:54 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 16:21:38 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (60001) as 180279

Powered by Google App Engine
This is Rietveld 408576698