Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: components/omnibox/search_suggestion_parser.h

Issue 470403003: [AiS] Fix parsing for Answers Images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/search_suggestion_parser.h
diff --git a/components/omnibox/search_suggestion_parser.h b/components/omnibox/search_suggestion_parser.h
index f65a0ba76cf9ba7bc4e27b9b352683ab9eed32f7..db7f1f4d56da0dd646afee7af1fff32f7c5a5edf 100644
--- a/components/omnibox/search_suggestion_parser.h
+++ b/components/omnibox/search_suggestion_parser.h
@@ -9,6 +9,7 @@
#include <vector>
#include "base/basictypes.h"
+#include "base/gtest_prod_util.h"
#include "base/strings/string16.h"
#include "components/omnibox/autocomplete_match.h"
#include "components/omnibox/autocomplete_match_type.h"
@@ -281,6 +282,11 @@ class SearchSuggestionParser {
Results* results);
private:
+ FRIEND_TEST_ALL_PREFIXES(SearchSuggestionParser,
+ GetAnswersImageURLsWithoutImagelines);
+ FRIEND_TEST_ALL_PREFIXES(SearchSuggestionParser,
+ GetAnswersImageURLsWithValidImage);
Mark P 2014/08/15 22:49:16 nit: can't you do this with only one line GetAnswe
groby-ooo-7-16 2014/08/22 00:43:58 Unfortunately not - it just makes sure MAYBE_ and
+
// Gets URLs of any images in Answers results.
static void GetAnswersImageURLs(const base::DictionaryValue* answer_json,
std::vector<GURL>* urls);

Powered by Google App Engine
This is Rietveld 408576698