Issue 470403002: Provide experimental AudioProcessing options at creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 470403002: Provide experimental AudioProcessing options at creation. (Closed)

Created:
6 years, 4 months ago by ajm

Modified:
6 years, 4 months ago

Reviewers:
bjornv, tommi (sloooow) - chröme

CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Provide experimental AudioProcessing options at creation. Remove now unneeded MediaStreamAudioProcessorOptions setters. Removes all calls to AudioProcessing::SetExtraOptions() from Chromium. TESTED=verified that options are set correctly in AudioProcessing. BUG=webrtc:3702 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289923

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -25 lines)			Patch
M	content/renderer/media/media_stream_audio_processor.cc	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	content/renderer/media/media_stream_audio_processor_options.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	content/renderer/media/media_stream_audio_processor_options.cc	View	2 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

The CQ bit was checked by tommi@chromium.org

6 years, 4 months ago (2014-08-15 07:35:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajm@chromium.org/470403002/1

6 years, 4 months ago (2014-08-15 07:38:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 289923

Expand Messages | Collapse Messages