IndexedDB: Measure the total database open time.

content/browser/indexed_db/indexed_db_dispatcher_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_dispatcher_host.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/memory/scoped_vector.h"
@@ skipping 273 matching lines @@
       new IndexedDBCallbacks(
           this, params.ipc_thread_id, params.ipc_callbacks_id),
       origin_url,
       indexed_db_path,
       request_context_);
 }
 
 void IndexedDBDispatcherHost::OnIDBFactoryOpen(
     const IndexedDBHostMsg_FactoryOpen_Params& params) {
   DCHECK(indexed_db_context_->TaskRunner()->RunsTasksOnCurrentThread());
+  base::TimeTicks begin_time = base::TimeTicks::Now();

[jsbell, 2014/08/14 22:58:06]

Why a temporary here rather than just passing in Now() below?

(it doesn't look like we do a measurable amount of work in between)

[cmumford, 2014/08/14 23:53:03]

Just being cautious. The stack value is super small and I wanted this to be a
bit more "future proof" so that if somebody puts in something that does take
time then it'll get measured.

If you want it removed let me know - no problem.

[jsbell, 2014/08/15 00:05:16]

It's fine as is, and I agree with your logic. :)

   base::FilePath indexed_db_path = indexed_db_context_->data_path();
 
   GURL origin_url =
       webkit_database::GetOriginFromIdentifier(params.database_identifier);
 
   int64 host_transaction_id = HostTransactionId(params.transaction_id);
 
   // TODO(dgrogan): Don't let a non-existing database be opened (and therefore
   // created) if this origin is already over quota.
   scoped_refptr<IndexedDBCallbacks> callbacks =
       new IndexedDBCallbacks(this,
                              params.ipc_thread_id,
                              params.ipc_callbacks_id,
                              params.ipc_database_callbacks_id,
                              host_transaction_id,
                              origin_url);
+  callbacks->SetDatbaseOpenStartTime(begin_time);
   scoped_refptr<IndexedDBDatabaseCallbacks> database_callbacks =
       new IndexedDBDatabaseCallbacks(
           this, params.ipc_thread_id, params.ipc_database_callbacks_id);
   IndexedDBPendingConnection connection(callbacks,
                                         database_callbacks,
                                         ipc_process_id_,
                                         host_transaction_id,
                                         params.version);
   DCHECK(request_context_);
   Context()->GetIDBFactory()->Open(
@@ skipping 671 matching lines @@
 }
 
 void IndexedDBDispatcherHost::CursorDispatcherHost::OnDestroyed(
     int32 ipc_object_id) {
   DCHECK(
       parent_->indexed_db_context_->TaskRunner()->RunsTasksOnCurrentThread());
   parent_->DestroyObject(&map_, ipc_object_id);
 }
 
 }  // namespace content